Sync gate: stall-window fencepost in the docs, `future` peers never age out, two doc typos
维护者通常 6 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 65/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- rust
调研方向
Start with the referenced sync gate code in crates/blockchain/src/sync_status.rs and the peer tracking code in crates/net/p2p/src/peer_heads.rs, then check their tests for stall timing and expiry behavior. The issue allows either changing the stall count or clarifying the docs; also expire future peer heads and fix the two specified documentation typos. Done when the timing is consistent, inactive future peers age out, and the documentation renders and reads correctly.
由索引模型根据 Issue 内容生成。
描述
Leftovers from the last review round of lambdaclass/ethlambda#791, which stopped at the review-round cap. None of them changes which way the gate decides, apart from one slot of timing in item 1.
- The stall window's fencepost.
StallCount::countcounts the first behind judgment as 0 (crates/blockchain/src/sync_status.rs:198), and the backstop trips onbehind_for > stall_window(sync_status.rs:358).- A node whose head stays flat therefore reads
syncing, skipping its duties, on 17 distinct slots on lean (33 on beacon).a_lead_that_never_turns_into_progress_is_a_stallpins this (last_syncing = 100 + stall_window). - The docs say 16 slots:
SyncThresholds::stall_window(crates/net/api/src/sync.rs),docs/spec_deviations.md, and.claude/skills/multi-server-devnet/references/node-health.md:94,108("after 16 slots of that"). - Fix either side: count the first behind slot (start at 1, adjust the tests and the randomized bounds), or say "more than 16 slots" in the docs.
PeerHeads::futurenever ages out (crates/net/p2p/src/peer_heads.rs:207).- A peer enters the set when its
Statushead is past the clock, and leaves it only on a later in-clockStatusor its disconnect (record,forget,peer_heads.rs:231-234). The report lifetime that ages claims (PeerHeads::expire,peer_heads.rs:263) does not apply. - A connected peer that reported a future head once and then stopped answering therefore stays counted in
lean_sync_peers_held_back{reason="future"}and in the slow-clock warning's majority. - The gate is unaffected, since a future head never counts.
- Fix: keep the wall slot with each entry and drop it in
expirewith the claims.
- A peer enters the set when its
- Typos.
docs/metrics.md,lean_sync_peers_held_backrow: a comma is missing after "range requests that kept failing)", before "peers cooling down".docs/spec_deviations.md: "consensus-specs has no sync gate, and the Beacon API leavesis_syncingto the client." needs a blank line before it. Without one it renders as part of the beacon paragraph above.
- 主要语言
- Rust
- 星标
- 86
- 派生
- 34
- 平均合并
- 9 天 20 小时
- 30 天内合并 PR
- 77
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
lambdaclass/ethlambda 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
lambdaclass/ethlambda#850 ·
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
lambdaclass/ethlambda#777 · 1 个 reaction ·
维护者通常 6 天内回复
-
Run all gossip validation tests可能重新可做 @dicethedev 于 9 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 62/100
lambdaclass/ethlambda#725 · 2 条评论 ·
维护者通常 6 天内回复
-
Handle malformed DB data可能重新可做 @dicethedev 于 115 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
lambdaclass/ethlambda#529 · 4 条评论 ·
维护者通常 6 天内回复
-
Document architectural choices可能重新可做 @dicethedev 于 115 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
lambdaclass/ethlambda#521 · 2 条评论 ·
维护者通常 6 天内回复
查看 lambdaclass/ethlambda 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
antithesishq/bombadil#473 ·
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
libracoder/kiri#669 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 5 天内回复
-
autofixer: follow-up
难度 2/5 1-3 小时 新手友好度 75/100
tursodatabase/turso#12217 ·
维护者通常 1 天内回复
-
Declare the CMS schema library in the optional recipients extra可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭area:python in-progress
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复