Drawer fork lets parent contexts leak in (no LayerContentBoundary)

未关闭
  • 哪里不对？
#89 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
42/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
react, typescript
领域
frontend

调研方向

Start with src/forks/Drawer/Drawer.tsx and compare its context behavior with Astryx 0.7.2's core Drawer, which wraps content in LayerContentBoundary. The issue gives two possible directions: request an exported boundary or move Modal and the notification stack onto the top layer so the fork can be removed. First determine which path maintainers choose; done means parent contexts no longer leak into drawer content, with the upstream test from #88 enabled or an equivalent check.

由索引模型根据 Issue 内容生成。

描述

Since Astryx 0.7.2, core's Drawer wraps its content in a private LayerContentBoundary, so contexts such as a disabled ButtonGroup or SizeContext around the trigger do not leak into the drawer. ui-common's Drawer fork (src/forks/Drawer/Drawer.tsx) cannot import that boundary, so those contexts still reach the drawer's content, as they did with lab's Drawer. The upstream test for it is skipped in #88.

Options:

  • ask Astryx to export LayerContentBoundary (or an equivalent reset), then use it in the fork;
  • move ui-common's Modal and the notification stack onto the top layer so the fork's reasons go away and it can be deleted in favour of core's Drawer.
主要语言
TypeScript
星标
2
派生
0
平均合并
1 天 1 小时
30 天内合并 PR
35

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

lablup/ui-common 的其他 Issue

查看 lablup/ui-common 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。