[BUG] OpenAI and Ollama adapters send an empty tool message when a tool returns a dict

未关闭 适合新手
#3,462 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
85/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
ai

调研方向

从 python/packages/kagent-adk/src/kagent/adk/models/_openai.py 中的 _extract_function_response_content 和 python/packages/kagent-adk/src/kagent/adk/models/_ollama.py 中的 _extract_response_content 开始;对于没有 content 列表或 result 键的 dict 结果,两者都返回空字符串。在 python/ 目录下运行 uv run python repro.py 复现脚本,查看空的工具消息。当两个辅助函数都将其他 dict 进行 JSON 编码(与 Go 的 extractFunctionResponseContent 保持一致),并且复现结果显示 dict 内容已传到模型时,即完成。

由索引模型根据 Issue 内容生成。

描述

📋 Prerequisites
  • I have searched the existing issues to avoid creating a duplicate
  • By submitting this issue, you agree to follow our Code of Conduct
  • I am using the latest version of the software
  • I have tried to clear cache/cookies or used incognito mode (if ui-related)
  • I can consistently reproduce this issue
🎯 Affected Service(s)

App Service

🚦 Impact/Severity

Blocker

🐛 Bug Description

When a tool returns a dict, the Python OpenAI and Ollama adapters send the model an empty tool message. The model never sees what the tool returned.

ADK passes a dict returned by a tool through unchanged (only non-dict results are wrapped as {"result": ...}), so this covers:

  • any tool that returns a dict, like the {"status": "success", "report": ...} style used in the ADK docs
  • ADK's own error responses, e.g. {"error": "Invoking get_weather() failed as the following mandatory input parameters are not present: city ..."} for a missing argument, an unknown tool name, or a rejected confirmation. The model is supposed to read these and retry, but it gets an empty message instead.
  • kagent's own tools that return dicts, e.g. ask_user ({"status": "pending", ...}) and the remote A2A tool ({"status": "failed", "error": ...})

Both helpers only handle a string, a dict with a content list (MCP results), or a dict with a result key, and return "" for everything else:

  • python/packages/kagent-adk/src/kagent/adk/models/_openai.py, _extract_function_response_content. Used for Chat Completions and the Responses API, so OpenAI, Azure OpenAI, Foundry and Mistral are all affected.
  • python/packages/kagent-adk/src/kagent/adk/models/_ollama.py, _extract_response_content

The Go ADK (extractFunctionResponseContent in go/adk/pkg/models/base.go) JSON-encodes other dicts, and the Python Bedrock and SAP AI Core adapters also send the dict as text, so only these two Python helpers drop it.

🔄 Steps To Reproduce

This runs a real ADK agent with kagent's OpenAI model against a small local fake OpenAI server that records the tool messages it receives. The fake model calls get_weather first without its argument, then with it.

import asyncio, json, threading
from http.server import BaseHTTPRequestHandler, HTTPServer
from google.adk.agents import Agent
from google.adk.runners import InMemoryRunner
from google.genai import types
from kagent.adk.models._openai import OpenAI

calls = ["{}", '{"city": "Paris"}']  # first without the required argument, then with it
sent = []

class FakeOpenAI(BaseHTTPRequestHandler):
    def do_POST(self):
        body = json.loads(self.rfile.read(int(self.headers["Content-Length"])))
        sent[:] = [m for m in body["messages"] if m["role"] == "tool"]
        if calls:
            msg = {"role": "assistant", "content": None, "tool_calls": [{"id": f"call_{len(sent) + 1}", "type": "function",
                   "function": {"name": "get_weather", "arguments": calls.pop(0)}}]}
        else:
            msg = {"role": "assistant", "content": "Done."}
        data = json.dumps({"id": "x", "object": "chat.completion", "created": 0, "model": "gpt-4o",
                           "choices": [{"index": 0, "message": msg, "finish_reason": "stop"}]}).encode()
        self.send_response(200); self.send_header("Content-Length", str(len(data))); self.end_headers(); self.wfile.write(data)

    def log_message(self, *args): pass

def get_weather(city: str) -> dict:
    """Get the current weather for a city."""
    return {"status": "success", "report": f"Sunny, 25C in {city}"}

async def main():
    server = HTTPServer(("127.0.0.1", 0), FakeOpenAI)
    threading.Thread(target=server.serve_forever, daemon=True).start()
    model = OpenAI(type="openai", model="gpt-4o", api_key="test", base_url=f"http://127.0.0.1:{server.server_port}/v1")
    runner = InMemoryRunner(agent=Agent(name="weather", model=model, tools=[get_weather]), app_name="demo")
    session = await runner.session_service.create_session(app_name="demo", user_id="u")
    msg = types.Content(role="user", parts=[types.Part.from_text(text="Weather in Paris?")])
    async for event in runner.run_async(user_id="u", session_id=session.id, new_message=msg):
        for part in event.content.parts if event.content else []:
            if part.function_response:
                print(f"tool result in ADK : {part.function_response.response}")
    for m in sent:
        print(f"sent to the model  : tool message for {m['tool_call_id']} -> content={m['content']!r}")

asyncio.run(main())

Run it from python/ with uv run python repro.py.

🤔 Expected Behavior

The model receives the tool result, e.g. the dict serialized as JSON:

sent to the model  : tool message for call_1 -> content='{"error": "Invoking `get_weather()` failed ..."}'
sent to the model  : tool message for call_2 -> content='{"status": "success", "report": "Sunny, 25C in Paris"}'
📱 Actual Behavior
tool result in ADK : {'error': 'Invoking `get_weather()` failed as the following mandatory input parameters are not present:\ncity\nYou could retry calling this tool, but it is IMPORTANT for you to provide all the mandatory parameters.'}
tool result in ADK : {'status': 'success', 'report': 'Sunny, 25C in Paris'}
sent to the model  : tool message for call_1 -> content=''
sent to the model  : tool message for call_2 -> content=''

The tool ran and ADK has both results, but both tool messages sent to the model are empty.

💻 Environment
  • OS and version: macOS 26.4 (arm64)
  • Application version: main at 12aa4d46, Python 3.13.15, google-adk 2.12.0
  • Kubernetes: not needed to reproduce (runs locally against a fake OpenAI server)
🔧 CLI Bug Report

No response

🔍 Additional Context

A possible fix is to fall back to json.dumps(response, default=str) in both helpers instead of returning "", which matches what the Go ADK does. I'd be happy to open a PR with that and unit tests for both adapters, if that sounds right.

📋 Logs

📷 Screenshots
Image
🙋 Are you willing to contribute?
  • I am willing to submit a PR to fix this issue
主要语言
Go
星标
4.1k
派生
859
平均合并
1 天 7 小时
30 天内合并 PR
174

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

kagent-dev/kagent 的其他 Issue

查看 kagent-dev/kagent 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。