Consider moving jar to Maven or eliminating entirely
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 12/100
- Issue 类型
- 重构
- 描述清晰度
- 需要澄清
- 活跃度
- 冷清
- 领域
- build-system
调研方向
Start by reading the Java sources that produce lib/warbler_jar.jar: WarblerJar and WarblerJarService (used by Warbler as a JRuby extension), and JarMain and WarMain (bootstrap entry points for generated jars and war files). The issue proposes several alternatives (Maven modules, moving code into JRuby, or rewriting parts in Ruby), so a contributor would first need a maintainer decision on which direction to take. Done would mean an agreed plan, not a patch.
由索引模型根据 Issue 内容生成。
描述
We currently build lib/warbler_jar.jar as part of this gem, even though most of it is not necessary for the execution of the gem.
Two classes in this jar are used by warbler as a JRuby extension to build the resulting archive: WarblerJar and WarblerJarService. None of this code really needs to be written in Java (it's largely just zip file manipulation and creation).
The remaining two sources built and installed in this jar are provided to bootstrap applications built by warbler (not to run warbler itself):
JarMain: provides a "main" entry point for standalone executable jars.WarMain: supports the embedded web application server used for executablewarfiles`.
These two classes could be moved to Maven modules and versioned from there. They could also be eliminated altogether:
- The
JarMainclass could be re-integrated back into JRuby, since it provides functionality the existing JRubyJarBootstrapMaindoes not. Building an executable jar would then just involve repackaging JRuby with appropriate layout and configuration to run the user's app. - The
WarMainclass could be generated, or written in Ruby with aJarMainbootstrap to run the ruby and then re-dispatch to the web server's main.
Eliminating the extension would get the gem back to a pure-Ruby construct and allow it to be run from any compatible Ruby implementation.
Transplanting or eliminating the "mains" would make it possible to build the warbler gem with any compatible Ruby implementation.
- 主要语言
- Ruby
- 星标
- 901
- 派生
- 206
- 平均合并
- 1 天 10 小时
- 30 天内合并 PR
- 3
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
jruby/warbler 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 35/100
-
难度 4/5 一周以上 新手友好度 25/100
-
难度 4/5 3-5 天 新手友好度 22/100
-
难度 5/5 一周以上 新手友好度 12/100
-
难度 4/5 3-5 天 新手友好度 25/100
相似的 Issue
-
Lint/NoReturnInMemoization flags `return` in local variable `||=` and `&&=` assignments可能已有人在做 @RaphaelFakhri 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 84/100
Shopify/ruby-style-guide#815 ·
-
难度 2/5 1-3 小时 新手友好度 83/100
zerocracy/judges-action#2849 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
bigbluebutton/bigbluebutton#26166 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 82/100
TarteelAI/quranic-universal-library#916 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复