limits= dict and list form don't allow full customizaton
维护者通常 1 天内回复
评估
调研方向
Start by reading the limits= handling in threadpool_limit() and the code that matches limits to detected libraries; the issue points to the comment describing prefix and user_api keys. Check how library filepaths are represented and used, then add coverage for two libraries with the same prefix. Done means a list or dict limit can target one library by its unique filepath.
由索引模型根据 Issue 内容生成。
描述
Starting point: we want custom limit for OpenBLAS with pthreads.
So we want to say one specific controller should have a different limit. In theory the relevant APIs (threadpool_limit() etc) support this by passing a list or a dict to the limits= parameter.
In practice, if you pass in a list or a dict it uses the prefix as the unique key, and prefix is not a unique key, different libraries can have the same prefix. So there is no way to specify just one library should have a different limit:
# self._limits is a dict {key: num_threads} where key is either
# a prefix or a user_api. If a library matches both, the limit
# corresponding to the prefix is chosen.
While real-world packaging choices of OpenBLAS may result in this not being a problem, that means it'd only work by accident.
The logic should really be using filepath as the first key to check, not prefix, since filepath is the only one guaranteed to be unique.
- 主要语言
- Python
- 星标
- 434
- 派生
- 38
- 平均合并
- 19 小时 28 分钟
- 30 天内合并 PR
- 6
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
joblib/threadpoolctl 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 57/100
joblib/threadpoolctl#276 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 25/100
joblib/threadpoolctl#271 ·
维护者通常 1 天内回复
-
Make it possible to inspect active/spin wait behavior of LLVM/Intel OpenMP via `kmp_get_blocktime`未关闭
难度 3/5 1-2 天 新手友好度 42/100
joblib/threadpoolctl#270 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 22/100
joblib/threadpoolctl#261 · 3 条评论 ·
维护者通常 1 天内回复
-
Opt-in API that has a cached `ThreadpoolController`可能已有人在做 @itamarst 于 33 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 25/100
joblib/threadpoolctl#254 · 3 条评论 ·
维护者通常 1 天内回复
查看 joblib/threadpoolctl 的全部 Issue
相似的 Issue
-
automated issue linkchecker report
难度 2/5 1-3 小时 新手友好度 66/100
QuantEcon/lecture-python.myst#1098 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
podly-pure-podcasts/podly_pure_podcasts#279 ·
维护者通常 1 天内回复
-
template-proposal
难度 1/5 1 小时以内 新手友好度 78/100
-
难度 1/5 1 小时以内 新手友好度 82/100
OpenShot/openshot-qt#6230 ·
维护者通常 1 天内回复