Bug in obfuscate js code.

未关闭
  • 哪里不对？
#24 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
javascript
领域
build-system, tooling

调研方向

未指定任何仓库文件、测试、版本或配置。首先通过 gulp 混淆管道复现所提供的 Painter 示例，并比较为 this.prePaint、this.paint 和 this.postPaint 生成的引用。完成的标准是，混淆后的代码保留可调用的属性引用，而不需要插入换行符。

由索引模型根据 Issue 内容生成。

描述

bug cannot reproduce

First at all, sorry for my english, i will try to explain it as better as possible.

I have the following js code:

    export const Painter = function (elements, data) {
        let title = elements.title;
        let container = elements.container;
        this.prePaint = () => { };
        this.paint = () => { };
        this.postPaint = () => { };
        let finalPaint = () => {
            this.prePaint = () => { };
            this.paint = () => { };
            this.postPaint = () => { };
            createPromise();
        };

        let createPromise = () => {
            return new Promise((resolve, reject) => {
                this.paint = () => { resolve() }
            }).then(() => {
                this.prePaint(elements, data);
                title.innerHTML = data.title;
                container.innerHTML = data.html;
                this.postPaint(elements, data);
                finalPaint();
            });
        }

        createPromise();
    };

When i obfuscate this code, it seems like this (it was minimized and formatted by the browser):

5: [function(a, b, c) {
        "use strict";
        Object[_0x56ae("0x6")](c, _0x56ae("0x6e"), {
            value: !0
        });
        c[_0x56ae("0xb5")] = function(a, b) {
            var c = this
              , d = a[_0x56ae("0xb6")]
              , e = a[_0x56ae("0xb7")];
            this.prePaint = function() {}      //// THIS LINE
            ,
            this[_0x56ae("0xb8")] = function() {}
            ,
            this[_0x56ae("0xb9")] = function() {}
            ;
            var f = function() {
                c[_0x56ae("0xba")] = function() {}
                ,
                c.paint = function() {}         ///// THIS LINE TOO
                ,
                c.postPaint = function() {}       ///// AND THIS LINE TOO
                ,
                g()
            }
              , g = function() {
                return new Promise(function(a) {
                    c.paint = function() {
                        a()
                    }
                }
                )[_0x56ae("0x24")](function() {
                    c[_0x56ae("0xba")](a, b),
                    d.innerHTML = b[_0x56ae("0xb6")],
                    e.innerHTML = b[_0x56ae("0x34")],
                    c.postPaint(a, b),
                    f()
                })
            };
            g()
        }
    }
    , {}]

You can see, how the fisrt this.prePaint has not transformed to this[_0x56ae("0xba")] and when this is called, it said undefined function.
But if i insert breaklines between all this "problematic" lines, it work. Like this:


export const Painter = function (elements, data) {
    let title = elements.title;
    let container = elements.container;

    this.prePaint = () => { };

    this.paint = () => { };

    this.postPaint = () => { };

    let finalPaint = () => {

        this.prePaint = () => { };

        this.paint = () => { };

        this.postPaint = () => { };

        createPromise();
    };

    let createPromise = () => {
        return new Promise((resolve, reject) => {

            this.paint = () => { resolve() }

        }).then(() => {
            this.prePaint(elements, data);

            title.innerHTML = data.title;
            container.innerHTML = data.html;

            this.postPaint(elements, data);

            finalPaint();

        });
    }

    createPromise();
};

I did fix this issue with this partial solution, but i don't know where more places of my code, will appear the same issue.

Thank you

主要语言
JavaScript
星标
103
派生
37
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

javascript-obfuscator/gulp-javascript-obfuscator 的其他 Issue

查看 javascript-obfuscator/gulp-javascript-obfuscator 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。