Debugger does not conform to DAP specification
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 30/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- python
调研方向
从 ipykernel/debugger.py 的 _handle_init_sequence 开始,并将其 request 处理方式与链接的 Microsoft 文档中的 DAP 初始化序列进行比较。跟踪 attach、配置请求和 configurationDone 当前的顺序;完成的标准是 kernel 能够支持所需的并行 requests,而不会在收到配置响应之前完成 attach。
由索引模型根据 Issue 内容生成。
描述
Per Microsoft's documentation for the Debug Adapter Protocol, a DAP client should send the launch/attach request in parallel with the various configuration requests, such as setBreakpoints and setExceptionBreakpoints. Only once those configuration requests have received responses should the client send configurationDone, at which time the adapter will return a response to the original launch/attach request. This allows the adapter to fully configure itself before the client considers itself attached.
ipykernel does not currently conform to this specification. It includes a _handle_init_sequence method which manually sends the configurationDone request to the adapter rather than use the original one from the client. It does this in response to the original attach request, too, well before the client would have sent that message itself.
This is problematic because:
- This method assumes DAP to work synchronously, whereas by definition the initialization sequence is meant to be conducted in parallel
- The
configurationDonerequest may make it to the adapter before the actual configuration requests (setBreakpoints...). This may cause issues (which we have actually seen) where the DAP client receives a response toattachbefore the adapter is done configuring. This leads to breakpoints not being set in time and ultimately being missed.
The root of this problem is the synchronous handling of DAP requests by ipykernel; the kernel cannot send Request B until Request A receives a response, so this parallel nature of initialization is currently not possible to conform to.
The solution to this problem would be to change how ipykernel handles DAP requests. One solution would be to use a queue to which requests are pushed, similar to how responses are handled. We can implement a working solution and submit a PR, if the maintainers are okay with it.
- 主要语言
- Python
- 星标
- 734
- 派生
- 411
- 平均合并
- 1 天 2 小时
- 30 天内合并 PR
- 9
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ipython/ipykernel 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 72/100
-
难度 4/5 3-5 天 新手友好度 48/100
-
难度 4/5 3-5 天 新手友好度 68/100
-
难度 3/5 1-2 天 新手友好度 66/100
查看 ipython/ipykernel 的全部 Issue
相似的 Issue
-
triage/confirmed
难度 2/5 1-3 小时 新手友好度 88/100
agentscope-ai/agentscope#2775 ·
-
comp/desktop P3 type/bug
难度 1/5 1 小时以内 新手友好度 92/100
NousResearch/hermes-agent#118866 ·
-
bug
难度 1/5 1 小时以内 新手友好度 90/100
apache/cloudstack#14222 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
-
bug
难度 2/5 1-3 小时 新手友好度 82/100