Incorrect stack traceback when try except finally is used in jupyter notebooks with pandas
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
调研方向
使用提供的 pandas DataFrame 示例在 Jupyter notebook 中复现该问题,并将其与 Dictionary KeyError 示例进行比较。检查 ipykernel 如何处理和呈现 try/except/finally 块的 traceback frame;完成的标准是,在 Jupyter 和 VSCode notebook 中,traceback 都指向 DataFrame 的构造,而不是 finally 块。
由索引模型根据 Issue 内容生成。
描述
Originally opened by @dvorst in https://github.com/jupyter/notebook/issues/7242
[✓] I checked the documentation and found no answer [✓] I checked to make sure that this issue has not already been filed [✓] I'm reporting the issue to the correct repository
Description
The stack traceback of some errors is displayed incorrectly. Below are two examples of an incorrect stacktrace and correct stacktrace. The incorrect one creates a pandas dataframe in a faulty manner, raising an exception, its stacktrace points to a command in the finally block instead of the pandas dataframe creation which is the actual issue.
The correct example shows how a non-existing key of a dictionary is called, its stacktrace does not point to a statement in the finally block but rather points to the line that actually causes the issue.
Some things i've tried or noticed:
* the correct example contains hyperlinks to each code-line, while the incorrect one doesn't, maybe this is a hint to the cause. I therefore included the stacktrace of both examples in raw text as well as html.
* running the'incorrect stacktrace' example in pure python (.py file) results in a **correct** stacktrace
* this issue occurs when hosting jupyter notebooks locally, but also in VSCode notebooks using the ipykernel
* Thinking that C-code extensions of Python could be a potential source, I also tried raising errors using torch (torch.tensor('invalid_type') but this results in a correct stacktrace.
* aside of torch i also tried incorrectly initiating classes with other packages, this also lead to a correct stacktrace
incorrect stacktrace
code
import pandas as pd
try:
pd.DataFrame(1)
except:
print("except")
raise
finally:
print("finally")
stacktrace text
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
/var/folders/j4/hhybm8xx3pb7nnmwfptdqng00000gp/T/ipykernel_40674/1767429816.py in ?()
5 except:
6 print("except")
7 raise
8 finally:
----> 9 print("finally")
~/Documents/projects/notebook-stacktrace-bug/.venv/lib/python3.12/site-packages/pandas/core/frame.py in ?(self, data, index, columns, dtype, copy)
871 )
872 # For data is scalar
873 else:
874 if index is None or columns is None:
--> 875 raise ValueError("DataFrame constructor not properly called!")
876
877 index = ensure_index(index)
878 columns = ensure_index(columns)
ValueError: DataFrame constructor not properly called!
stacktrace html
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
[/var/folders/j4/hhybm8xx3pb7nnmwfptdqng00000gp/T/ipykernel_40674/1767429816.py](https://file+.vscode-resource.vscode-cdn.net/var/folders/j4/hhybm8xx3pb7nnmwfptdqng00000gp/T/ipykernel_40674/1767429816.py) in ?()
5 except:
6 print("except")
7 raise
8 finally:
----> 9 print("finally")
[~/Documents/projects/notebook-stacktrace-bug/.venv/lib/python3.12/site-packages/pandas/core/frame.py](https://file+.vscode-resource.vscode-cdn.net/Users/dvorst/Documents/projects/notebook-stacktrace-bug/~/Documents/projects/notebook-stacktrace-bug/.venv/lib/python3.12/site-packages/pandas/core/frame.py) in ?(self, data, index, columns, dtype, copy)
871 )
872 # For data is scalar
873 else:
874 if index is None or columns is None:
--> 875 raise ValueError("DataFrame constructor not properly called!")
876
877 index = ensure_index(index)
878 columns = ensure_index(columns)
ValueError: DataFrame constructor not properly called!
correct stacktrace
code
some_dict = {}
try:
some_dict['non-existent-key']
except:
print("except")
raise
finally:
print("finally")
stacktrace text
---------------------------------------------------------------------------
KeyError Traceback (most recent call last)
Cell In[6], line 3
1 some_dict = {}
2 try:
----> 3 some_dict['non-existent-key']
4 except:
5 print("except")
KeyError: 'non-existent-key'
stacktrace html
---------------------------------------------------------------------------
KeyError Traceback (most recent call last)
Cell In[6], [line 3](vscode-notebook-cell:?execution_count=6&line=3)
[1](vscode-notebook-cell:?execution_count=6&line=1) some_dict = {}
[2](vscode-notebook-cell:?execution_count=6&line=2) try:
----> [3](vscode-notebook-cell:?execution_count=6&line=3) some_dict['non-existent-key']
[4](vscode-notebook-cell:?execution_count=6&line=4) except:
[5](vscode-notebook-cell:?execution_count=6&line=5) print("except")
KeyError: 'non-existent-key'
Context
This occurs in the browser with notebook 7.0.7, but also in VSCode notebooks with ipykernel 6.29.2
* Operating System and version: macOS 14.2
* Browser and version: Firefox 122.0.1 though this shouldn't matter as the issue also occurs in VSCode
IPython : 8.21.0 ipykernel : 6.29.2 ipywidgets : not installed jupyter_client : 8.6.0 jupyter_core : 5.7.1 jupyter_server : 2.12.5 jupyterlab : 4.1.0 nbclient : 0.9.0 nbconvert : 7.16.0 nbformat : 5.9.2 notebook : 7.0.7 qtconsole : not installed traitlets : 5.14.1
pandas : 2.2.0 vscode. : 1.86.0
Troubleshoot Output
I did not include the command line output as this caused the maximum amount of characters allowed to be exceeded.
- 主要语言
- Python
- 星标
- 734
- 派生
- 411
- 平均合并
- 1 天 2 小时
- 30 天内合并 PR
- 9
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ipython/ipykernel 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 72/100
-
难度 4/5 3-5 天 新手友好度 48/100
-
难度 4/5 3-5 天 新手友好度 68/100
-
难度 3/5 1-2 天 新手友好度 66/100
查看 ipython/ipykernel 的全部 Issue
相似的 Issue
-
triage/confirmed
难度 2/5 1-3 小时 新手友好度 88/100
agentscope-ai/agentscope#2775 ·
-
comp/desktop P3 type/bug
难度 1/5 1 小时以内 新手友好度 92/100
NousResearch/hermes-agent#118866 ·
-
bug
难度 1/5 1 小时以内 新手友好度 90/100
apache/cloudstack#14222 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
-
bug
难度 2/5 1-3 小时 新手友好度 82/100