Set Pinning - Doesn't send the folder name

未关闭
#2,067 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

  • #2506 来自 @sap1110 —— 已关闭,未合并

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
javascript, react
领域
api, frontend

调研方向

首先跟踪 Settings 和文件列表中的“set pinning”流程,直到 issue 中描述的 POST 请求,并比较文件夹名称存在和缺失的情况。使用 Pinning Service API 的开发实例验证 fix,并确认 payload 除了 cid 和 origins 外还包含 name。

由索引模型根据 Issue 内容生成。

描述

effort/hours exp/beginner good first issue kind/bug P0 status/ready
  • OS: macOs
  • Version of IPFS Desktop: 0.24.0

Describe the bug
When pinning a folder to a remote service through the Pinning Service API, the client sometimes does not send the name over.
The payload of the POST request sent contains the cid and origins but no name.

This has been raised by a user on a web3.storage issue.
To verify it wasn't a problem in web3.storage implementation I tested this against a development instance of the service and logged Add pin payload to confirm no name is provided.

Unfortunately, this happens randomly, it sometimes does and sometimes doesn't, and I couldn't quite figure out a consistent way to reproduce it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'settings'
  2. Add web3.storage
  3. Go to the file list
  4. Click on the 3 dots on the right -> set pinning to the newly added service
  5. Navigate to https://web3.storage/account/?table=pinned
  6. See file appearing with "no name"

Expected behavior
It should send the name.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Please be aware that in order to be able to be able to pin on Web3.storage you need to have the PSA enabled, see docs.
In order to see the table you need to have at least a succesful pin.

Example of payload sent:

{
    "cid": "QmeWZGxrwPyR532r4HTHUwWo6zJPZKxzPMnsm3Smbi2TDv",
    "origins": [
        "/ip4/192.168.1.3/tcp/4001/p2p/12D3KooWF59pZMi2q4qqqz6Mimi5oULWFQABYGXSQjNkR6sKC1kD",
        .. more origins
    ]
}
主要语言
JavaScript
星标
1.6k
派生
539
PR 合并指标
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

ipfs/ipfs-webui 的其他 Issue

查看 ipfs/ipfs-webui 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。