bug: ActionSheet CSS custom properties are applied to 'selected' role button since 8.7.12
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- angular, css, typescript
- 领域
- frontend
调研方向
使用链接的 ionic-action-sheet-bug 仓库重现该问题,对比 @ionic/angular 8.7.12 和 8.7.11。然后检查 pull request #30769 中引用的更改,并验证选中的 ActionSheet 按钮会接收 action-sheet-selected 并应用自定义的 --button-color-selected 样式。
由索引模型根据 Issue 内容生成。
描述
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
v8.x
Current Behavior
When we set the role: 'selected' property on an ActionSheetButton the rendered html button is missing class action-sheet-selected. This results in missing applied css styles applied, e.g. if we set --button-color-selected on for the action sheet's custom css class, that style is not shown.
Example ActionSheetButton
{
text: 'Share',
role: 'selected',
data: {
action: 'share',
},
},
Other action-sheet-ROLE classes (e.g. destructive are still applied to the button.
Expected Behavior
The css class action-sheet-selected is applied if a button's role is set to selected and therefore the custom css properties are taking action.
For instance if I set --button-color-selected: purple; (with a proper css class attached to my action sheet) I expect that the button with role selected is showing a purple text color.
Steps to Reproduce
- go to https://github.com/pjaecks-carecompass/ionic-action-sheet-bug
- clone repository
npm ci- this will install@ionic/[email protected]npm start, openhttp://localhost:4200- tap the "Open" button to show the
ActionSheet - check for the text color of the "Share" button - it is the default text color
- now install previous ionic angular version with
npm install --save --save-exact @ionic/[email protected] - repeat step 4 and 5
- check the text color of the "Share" button - this is now purple because the styling defined in
app.component.scssis applied
Code Reproduction URL
https://github.com/pjaecks-carecompass/ionic-action-sheet-bug
Ionic Info
Ionic:
Ionic CLI : 5.4.16 (/home/USER/.npm/_npx/864a9e3c2cd0cf50/node_modules/ionic)
Ionic Framework : not installed
@angular-devkit/build-angular : 20.3.14
@angular-devkit/schematics : 20.3.14
@angular/cli : 20.3.14
@ionic/angular-toolkit : 12.3.0
Utility:
cordova-res : not installed
native-run (update available: 2.0.3) : 2.0.1
System:
NodeJS : v22.21.0 (/home/USER/.nvm/versions/node/v22.21.0/bin/node)
npm : 10.9.4
OS : Linux 6.6
Additional Information
I suspect https://github.com/ionic-team/ionic-framework/pull/30769 to introduce this.
This change (bug?) was introduced in 8.7.12.
With 8.7.11 it is still working fine.
- 主要语言
- TypeScript
- 星标
- 52.8k
- 派生
- 13.3k
- 平均合并
- 3 天 1 小时
- 30 天内合并 PR
- 78
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
ionic-team/ionic-framework 的其他 Issue
-
bug: input-otp, backspace in an empty box only moves focus instead of clearing the previous box可能已有人在做 @sarankumar1325 于 24 天前认领。 未关闭package: core type: bug
难度 2/5 1-3 小时 新手友好度 90/100
ionic-team/ionic-framework#31639 · 1 条评论 ·
维护者通常 1 天内回复
-
bug: vue swipe cancellation throws when the previous page is missing可能已有人在做 @dandoingdev 于 47 天前认领。 未关闭package: vue type: bug
难度 2/5 1-3 小时 新手友好度 78/100
ionic-team/ionic-framework#31514 · 1 条评论 ·
维护者通常 1 天内回复
-
bug: ion-searchbar input is always labelled "search text"; aria-label on the host is not forwarded可能已有人在做 @HappyKnuckles 于 41 天前认领。 未关闭a11y package: core type: bug
难度 2/5 1-3 小时 新手友好度 84/100
ionic-team/ionic-framework#31492 · 1 条评论 ·
维护者通常 1 天内回复
-
bug: IonTabs throws when a Fragment contains one IonRouterOutlet可能已有人在做 @Benziza 于 82 天前认领。 未关闭package: react type: bug
难度 2/5 1-3 小时 新手友好度 72/100
ionic-team/ionic-framework#31410 · 2 条评论 ·
维护者通常 1 天内回复
-
bug: angular swipe-back gesture crashes in StackController.startBackTransition when the stack is popped before the gesture is captured可能已有人在做 @officialasishkumar 于 10 天前认领。 未关闭package: angular type: bug
难度 2/5 1-3 小时 新手友好度 86/100
ionic-team/ionic-framework#31291 · 1 条评论 ·
维护者通常 1 天内回复
查看 ionic-team/ionic-framework 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
vercel-labs/ui#809 ·
维护者通常 1 天内回复
-
bot:ai-assisted component:platform-js status:untriaged
难度 1/5 1 小时以内 新手友好度 74/100
midnightntwrk/platform-js#38 ·
-
[bug] Second false positive on high-cost plugin alert: detection only compares patch entry id, community plugin dsh-auto | [bug] 高成本插件告警第二次误报:检测只比对 patch 条目 id,社区插件 dsh-auto-review 被认成 @deepseek-ai/dsh-experimental-auto-review可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
ranxianglei/billion-context#7068 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
mybigday/whisper.rn#348 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
six-group/six-webcomponents#600 ·