bug(geolocation): iOS requestPermissions never settles after "Allow Once" lapses, and the plugin prompts unasked

未关闭
  • 哪里不对？
#2,624 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
ios, swift
领域
mobile

调研方向

Start in GeolocationPlugin.swift: read requestPermissions, bindAuthorisationStatusPublisher (the .notDetermined sink), and handleLocationRequest, along with the callback manager's requestPermissionsCallbacks, locationCallbacks and watchCallbacks. Reproduce on an iOS simulator by choosing "Allow Once", backgrounding the app, then calling requestPermissions again. Done means that call resolves or shows a prompt when the status is .notDetermined, and that no system prompt appears without a pending JS call.

由索引模型根据 Issue 内容生成。

描述

platform: ios

Bug Report

Plugin(s)

@capacitor/geolocation 8.2.4 (iOS). The same code is in 9.0.0-next.3.

Capacitor Version

@capacitor/core and @capacitor/ios 8.5.3; iPhone 16 Pro simulator, iOS 18.3.

Platform(s)

iOS

Current Behavior

Two problems, both from how GeolocationPlugin.swift handles the .notDetermined status.

1. requestPermissions() (and getCurrentPosition()) never settle after "Allow Once" lapses.

  1. Call requestPermissions() and choose Allow Once, then getCurrentPosition(): works.
  2. Send the app to the background (for example, open Apple Maps). About 10 seconds later iOS ends the one-time grant and the status becomes .notDetermined.
  3. The plugin's authorisationStatusPublisher sink sees .notDetermined and calls requestLocationAuthorisation by itself. The app is not in use, so locationd drops it: 
    locationd: {"msg":"#AuthPrompt #Warning Dropping authorization request placed while insufficiently in-use", "ClientKeyPath":"i<bundle id>:", "requestType":2, "inUseLevel":0}
  4. Back in the app, call checkPermissions() (returns prompt), then requestPermissions(). Because the status is already .notDetermined, requestPermissions only adds the call to requestPermissionsCallbacks and waits for the publisher. The publisher never fires again, since nothing changes, and no new authorisation request is made. The promise never resolves or rejects. getCurrentPosition parks the same way (default: break in handleLocationRequest), and its timeout does not help because the timer only starts in requestSingleLocation, after authorisation.

Every later call hangs too, until the app process is restarted.

2. A permission prompt appears without any call.

Once any plugin method has been called in the process, the sink stays subscribed. Whenever the status changes to .notDetermined while the app is active, the sink requests authorisation, and the system prompt appears over whatever screen is open, with no JS call behind it:

locationd: {"msg":"Showing #AuthPrompt", "requestType":2, "Client":"i<bundle id>:"}
Expected Behavior
  • requestPermissions() shows the prompt (or resolves) whenever the status is .notDetermined at the time of the call.
  • The plugin only asks for authorisation on behalf of a pending call.
Code Reproduction
await Geolocation.requestPermissions({ permissions: ['coarseLocation'] }); // choose "Allow Once"
await Geolocation.getCurrentPosition();                                    // works
// background the app for ~10 s, return
await Geolocation.checkPermissions();                                      // { coarseLocation: 'prompt' }
await Geolocation.requestPermissions({ permissions: ['coarseLocation'] }); // never settles
Additional Context

The patch we ship (patch-package), which fixes both cases in our testing:

@@ requestPermissions
         if locationService?.authorisationStatus == .notDetermined {
             shouldSetupBindings()
             callbackManager?.addRequestPermissionsCallback(capacitorCall: call)
+            requestLocationAuthorisation(type: .whenInUse)
         } else {
@@ bindAuthorisationStatusPublisher
                 case .notDetermined:
-                    self.requestLocationAuthorisation(type: .whenInUse)
+                    if self.hasPendingCallbacks() {
+                        self.requestLocationAuthorisation(type: .whenInUse)
+                    }
@@ handleLocationRequest
         case .restricted: callbackManager?.sendError(.permissionRestricted)
+        case .notDetermined: requestLocationAuthorisation(type: .whenInUse)
         default: break
@@
+    func hasPendingCallbacks() -> Bool {
+        guard let callbackManager else { return false }
+        return !callbackManager.requestPermissionsCallbacks.isEmpty
+            || !callbackManager.locationCallbacks.isEmpty
+            || !callbackManager.watchCallbacks.isEmpty
+    }
主要语言
Java
星标
688
派生
691
平均合并
1 天 15 小时
30 天内合并 PR
3

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

ionic-team/capacitor-plugins 的其他 Issue

查看 ionic-team/capacitor-plugins 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。