Windows: PEB-less processes and kernel scan robustness

未关闭
  • 哪里不对？
#433 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
56/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust
领域
operating-systems, security

调研方向

Start by reading the named Windows code in src/os/windows/structs.rs, kernel.rs, debug_info.rs, util.rs, and pdb.rs, tracing the PEB lookup and kernel scan paths. Check how debug-info sizes and strings are read, then add bounds and null handling consistent with nearby code. Done means malformed or unreadable guest data cannot panic, hang, or underflow, and the kernel scan continues past unmapped pages; the issue says this has not yet been reproduced under SIMICS.

由索引模型根据 Issue 内容生成。

描述

Where

  • src/os/windows/structs.rs:2747 (base_address), called from kernel.rs:428
  • src/os/windows/kernel.rs 124-142
  • src/os/windows/debug_info.rs 61-62, 85-87; util.rs 205-219; pdb.rs 33-50

Problem

  • base_address() reads the PEB at 0 when Peb == NULL (System process).
  • Kernel scan propagates the first unmapped-page error instead of continuing; scan_address -= step can underflow.
  • info[0]/info[1] panic on a short user debug_info entry; guest-controlled debug-directory size and NUL-terminated string reads are unbounded; RSDS signature checked after the unbounded read.

Impact
A harness started from a system thread fails fuzzing start; malformed guest data can hang or panic.

Suggested fix
Null-check the PEB, treat unreadable pages as non-kernel with checked_sub, validate lengths and cap reads.

Status
Reported by static code review at 79972db; not yet re-verified line by line. Found by reading the code; not reproduced under SIMICS.

主要语言
Rust
星标
335
派生
26
平均合并
1 天 50 分钟
30 天内合并 PR
12

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

intel/tsffs 的其他 Issue

查看 intel/tsffs 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。