Simulation stop without reason sends a fake `Ok` and desynchronises testcases and results
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Read src/haps/mod.rs around on_simulation_stopped_without_reason and src/fuzzer/mod.rs around the referenced exit handling. Trace how an iteration’s exit kind and timeout are managed, then verify the suggested behavior against the surrounding callbacks. Done means a stop without a reason leaves the iteration pending without shifting later testcase results; the issue says this has not yet been reproduced under SIMICS.
由索引模型根据 Issue 内容生成。
描述
Where
- https://github.com/intel/tsffs/blob/79972db9c63eba3ac8a1ce348264eee2005b2b16/src/haps/mod.rs#L493-L531
- https://github.com/intel/tsffs/blob/79972db9c63eba3ac8a1ce348264eee2005b2b16/src/fuzzer/mod.rs#L533-L537
Problem
on_simulation_stopped_without_reason sends ExitKind::Ok for the iteration still in flight and cancels its timeout.
Impact
User pauses mid-iteration (Ctrl-C, unrelated breakpoint) and continues: the fuzzer has consumed Ok for T1 and moved to T2; when T1 really finishes, its result is attributed to T2 and every later result is off by one (non-crashing inputs saved as solutions). The rest of T1 runs with no timeout. With shutdown_on_stop_without_reason = True the thread exits later and the next channel send/recv panics in a HAP callback.
Suggested fix
When not shutting down, send no exit kind and keep the timeout armed; leave the iteration pending.
Status
Reported by static code review at 79972db; not yet re-verified line by line. Found by reading the code; not reproduced under SIMICS.
- 主要语言
- Rust
- 星标
- 335
- 派生
- 26
- 平均合并
- 1 天 50 分钟
- 30 天内合并 PR
- 12
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
intel/tsffs 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 86/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
相似的 Issue
-
bug UI
难度 2/5 1-3 小时 新手友好度 70/100
wardian-app/Wardian#1746 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
jlcodes99/cockpit-tools#3125 ·
维护者通常 2 天内回复
-
bug user-sprint
难度 2/5 1-3 小时 新手友好度 72/100
Vondor/KassenSturz#967 ·
维护者通常 1 天内回复
-
area/ci
难度 1/5 1 小时以内 新手友好度 62/100
维护者通常 1 天内回复
-
[BUG] Incremental sync warns "no stored highest_uid" on every round for folders with no new mail未关闭bug
难度 2/5 1-3 小时 新手友好度 70/100
rustmailer/bichon#411 ·