Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Reading and writing in sync mode problems after update to 1.4

未关闭
#827 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
30/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
csharp
领域
tooling

调研方向

从链接的 Save.cs 中第 242 行和第 328 行附近的位置开始,然后沿着两条堆栈跟踪检查 TarBuffer.ReadBlockIntAsync 和 ZipStrings/StringCodec。在报告的 Mono/Godot 环境下复现 tar.gz 写入和同步读取路径;当两条路径都能通过 SharpZipLib 1.4.2 稳定工作时,即视为完成。

由索引模型根据 Issue 内容生成。

描述

bug gzip tar
Describe the bug

I'm seeing issues in both reading data and writing data after updating this library from 1.3.3 to 1.4.2 (I think also an earlier 1.4.x version had similar issues).

For reading I randomly see the following issue (I use sync reading):

System.ArgumentException: BUG: buffer must have length BlockSize
  at ICSharpCode.SharpZipLib.Tar.TarBuffer.ReadBlockIntAsync (System.Byte[] buffer, System.Threading.CancellationToken ct, System.Boolean isAsync) [0x00023] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at System.Threading.Tasks.ValueTask.ThrowIfCompletedUnsuccessfully () [0x0001b] in <c50882760828481c927e00b7db67d1a5>:0 
  at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult () [0x00000] in <c50882760828481c927e00b7db67d1a5>:0 
  at ICSharpCode.SharpZipLib.Tar.TarInputStream.GetNextEntryAsync (System.Threading.CancellationToken ct, System.Boolean isAsync) [0x0016a] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at System.Threading.Tasks.ValueTask`1[TResult].get_Result () [0x00022] in <c50882760828481c927e00b7db67d1a5>:0 
  at System.Runtime.CompilerServices.ValueTaskAwaiter`1[TResult].GetResult () [0x00000] in <c50882760828481c927e00b7db67d1a5>:0 
  at ICSharpCode.SharpZipLib.Tar.TarInputStream.GetNextEntry () [0x00015] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at (wrapper remoting-invoke-with-check) ICSharpCode.SharpZipLib.Tar.TarInputStream.GetNextEntry()
  at Save.LoadDataFromFile (System.String file, System.Boolean info, System.Boolean save, System.Boolean screenshot) [0x0018e] in /home/hhyyrylainen/Projects/Thrive/src/saving/Save.cs:363 
  at Save.LoadFromFile (System.String file, System.Boolean info, System.Boolean save, System.Boolean screenshot, System.Action readFinished) [0x00035] in /home/hhyyrylainen/Projects/Thrive/src/saving/Save.cs:281 
  at Save.LoadFromFile (System.String saveName, System.Action readFinished) [0x00008] in /home/hhyyrylainen/Projects/Thrive/src/saving/Save.cs:89 
  at InProgressLoad.Step () [0x00097] in /home/hhyyrylainen/Projects/Thrive/src/saving/InProgressLoad.cs:101 

I assume the exception BUG: buffer must have length BlockSize means that there is likely a bug in this library?

The other issue is in writing data, I use this in a game using Godot engine which means that the mono runtime is used, which might be the cause of this exception:

System.TypeInitializationException: The type initializer for 'ICSharpCode.SharpZipLib.Zip.ZipStrings' threw an exception. ---> System.EntryPointNotFoundException: GetCPInfoExW assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) Interop+Kernel32.GetCPInfoExW(uint,uint,Interop/Kernel32/CPINFOEXW*)
  at Interop+Kernel32.TryGetACPCodePage (System.Int32& codePage) [0x00000] in <8020ff214f044836812da4de6be2aa56>:0 
  at System.Text.CodePagesEncodingProvider.get_SystemDefaultCodePage () [0x00000] in <8020ff214f044836812da4de6be2aa56>:0 
  at System.Text.CodePagesEncodingProvider.GetEncoding (System.Int32 codepage) [0x00011] in <8020ff214f044836812da4de6be2aa56>:0 
  at System.Text.EncodingProvider.GetEncodingFromProvider (System.Int32 codepage) [0x00017] in <5cf9631a76c548989e3186162d571fee>:0 
  at System.Text.Encoding.GetEncoding (System.Int32 codepage) [0x00000] in <5cf9631a76c548989e3186162d571fee>:0 
  at ICSharpCode.SharpZipLib.Zip.StringCodec.get_SystemDefaultEncoding () [0x00000] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at ICSharpCode.SharpZipLib.Zip.StringCodec.get_Default () [0x00000] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at ICSharpCode.SharpZipLib.Zip.ZipStrings..cctor () [0x00000] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
   --- End of inner exception stack trace ---
  at ICSharpCode.SharpZipLib.Zip.Compression.Streams.DeflaterOutputStream..ctor (System.IO.Stream baseOutputStream, ICSharpCode.SharpZipLib.Zip.Compression.Deflater deflater, System.Int32 bufferSize) [0x00007] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at ICSharpCode.SharpZipLib.GZip.GZipOutputStream..ctor (System.IO.Stream baseOutputStream, System.Int32 size) [0x00014] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at ICSharpCode.SharpZipLib.GZip.GZipOutputStream..ctor (System.IO.Stream baseOutputStream) [0x00000] in <82d3b1a41c8a4daeb7a8d496582b1183>:0 
  at (wrapper remoting-invoke-with-check) ICSharpCode.SharpZipLib.GZip.GZipOutputStream..ctor(System.IO.Stream)
  at Save.WriteDataToSaveFile (System.String target, System.String justInfo, System.String serialized, Godot.Image screenshot) [0x00049] in /home/hhyyrylainen/Projects/Thrive/src/saving/Save.cs:252 
  at Save.WriteRawSaveDataToFile (SaveInformation saveInfo, System.String saveContent, Godot.Image screenshot, System.String saveName) [0x00020] in /home/hhyyrylainen/Projects/Thrive/src/saving/Save.cs:239 
  at Save.SaveToFile () [0x00001] in /home/hhyyrylainen/Projects/Thrive/src/saving/Save.cs:214 
  at SaveHelper.PerformSave (InProgressSave inProgress, Save save) [0x0004e] in /home/hhyyrylainen/Projects/Thrive/src/saving/SaveHelper.cs:540 
  at SaveHelper+<>c__DisplayClass28_0.<InternalSaveHelper>b__1 (InProgressSave inProgress, Save save) [0x00028] in /home/hhyyrylainen/Projects/Thrive/src/saving/SaveHelper.cs:467 
  at InProgressSave.Step () [0x00155] in /home/hhyyrylainen/Projects/Thrive/src/saving/InProgressSave.cs:226 
  at Invoke._Process (System.Single delta) [0x0003c] in /home/hhyyrylainen/Projects/Thrive/src/engine/Invoke.cs:45 

I tried looking but there doesn't seem to be a GZipOutputStream constructor that takes in an encoding object.

Reproduction Code

No response

Steps to reproduce

Try to write a tar.gz file in the following way:

https://github.com/Revolutionary-Games/Thrive/blob/a8ad16dfd02cda02839158149546b0362644f6c3/src/saving/Save.cs#L242

Or try to read such a created file like this (normal tar on my system can extract the file perfectly, which I think indicates that the 1.3.3 created file is fully correct):
https://github.com/Revolutionary-Games/Thrive/blob/a8ad16dfd02cda02839158149546b0362644f6c3/src/saving/Save.cs#L328

Expected behavior

I expect that the code, which I linked above, would work in version 1.4.2. I hope I didn't use the library incorrectly, which is possible. I tried searching but I didn't find any porting guide for what changes I would need to make to keep my code working with 1.4.2 version.

Operating System

Linux

Framework Version

Other

Tags

GZip, Tar

Additional context

Update: I tried switching out the gzip layer from this library for the .NET system one and with that everything seems to work correctly. Or at least the error is so rare that I didn't manage to see it from a couple of testing runs. So maybe the issue is reading a combined tar and gzip (from this library) stream in a sync manner?

主要语言
C#
星标
3.9k
派生
1k
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

icsharpcode/SharpZipLib 的其他 Issue

查看 icsharpcode/SharpZipLib 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。