VB -> C#: Static variables are supposed to be lazy initialized inside method/property

未关闭
#868 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
csharp, visualbasic
领域
tooling

调研方向

在 CodeConverter 网站中复现 issue 中的 VB-to-C# 转换,然后跟踪生成字段初始化器的 VB static-local 转换路径。将生成的输出与预期的延迟初始化进行比较,并验证重复和并发访问属性时的行为;完成的标准是初始化器会延迟到属性被使用时才执行,并且转换后的代码保留所需的语义。

由索引模型根据 Issue 内容生成。

描述

VB -> C#
VB.Net input code
Public Class VisualBasicClass

    Sub Main
        Console.WriteLine(Example)
    End Sub

    Public Readonly Property Example As Long 
        Get
            Static StaticVar As Long  = LongRunningFunction
            Return StaticVar -1 
        End Get
    End Property

    Public Shared Function LongRunningFunction As Long 
        Dim i  As Long = 1
        While i<10000000000
            i +=1
        End While  
    Return i
    End Function 
End Class
Erroneous output

public partial class VisualBasicClass
{
    public void Main()
    {
        Console.WriteLine(Example);
    }

    private long _Example_StaticVar = LongRunningFunction();

    public long Example
    {
        get
        {
            return _Example_StaticVar - 1L;
        }
    }

    public static long LongRunningFunction()
    {
        long i = 1L;
        while (i < 10000000000L)
            i += 1L;
        return i;
    }
}
Expected output

public partial class VisualBasicClass
{
    public void Main()
    {
        Console.WriteLine(Example);
    }

        private long _Example_StaticVar;
	private bool _Example_StaticVar_Init;

    public long Example
    {
        get
        {
			if (!_Example_StaticVar_Init) {
				_Example_StaticVar = LongRunningFunction();
				_Example_StaticVar_Init=true;
			}
            return _Example_StaticVar - 1L;
        }
    }

    public static long LongRunningFunction()
    {
        long i = 1L;
        while (i < 10000000000L)
            i += 1L;
        return i;
    }
}
Details
  • Website aka codeconverter.icsharpcode.net
  • Version in use: 8.4.7.0
  • Never saw it working
  • While Static variables aren't common, when using a static variable the lazy initialization is IMO essential. The "suggested" code isn't thread safe, unlike the VB code, but it's probably what most people would write as an equivalent. A more exact conversion of the Example property would be:
readonly Microsoft.VisualBasic.CompilerServices.StaticLocalInitFlag _Example_StaticVar_Init = new Microsoft.VisualBasic.CompilerServices.StaticLocalInitFlag();
 private long _Example_StaticVar;

public long Example
{
	get
	{
		bool InitStaticVariableHelper(Microsoft.VisualBasic.CompilerServices.StaticLocalInitFlag flag)
		{
			if (flag.State == 0)
			{
				flag.State = 2;
				return true;
			}
			else if (flag.State == 2)
			{
				throw new Microsoft.VisualBasic.CompilerServices.IncompleteInitialization();
			}
			else
			{
				return false;
			}
		}

		lock (_Example_StaticVar_Init)
		{
			try
			{
				if (InitStaticVariableHelper(_Example_StaticVar_Init))
				{
					_Example_StaticVar = LongRunningFunction();
				}
			}
			finally
			{
				_Example_StaticVar_Init.State = 1;
			}
		}
		return _Example_StaticVar;
	}
}

On one hand this is fairly close to an exact translation, on the other hand it's ugly. I would actually come down on the side of more exact translation (I do use it for the thread safety in a couple of places), but would understand if you felt it was too much, and the thread safety probably isn't all that important to most people (said without any basis other than a WAG).

主要语言
C#
星标
918
派生
244
平均合并
1 天 10 小时
30 天内合并 PR
29

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

icsharpcode/CodeConverter 的其他 Issue

查看 icsharpcode/CodeConverter 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。