Interactions between Lolex, Timecop and the Cache in HyperSpec

未关闭

#452 创建于 2023年2月23日 0 条评论 0 个 reaction 已指派 0 人在 GitHub 查看

还没有人认领这个 Issue。

评估

难度: 4/5
预计耗时: 3-5 天
新手友好度: 35/100

Issue 类型: 缺陷
描述清晰度: 基本清楚
活跃度: 停滞
技术栈: ruby
领域: testing

调研方向

首先定位 HyperSpec::Internal::Controller 的 cache_read、cache_write 和 cache_delete 方法，然后检查 Lolex.evaluate_ruby 以及 Filecache 和 Timecop 在其中如何交互。完成的标准是缓存操作使用系统时间，并且在 HyperSpec 未挂载时保留 Lolex 更新，同时不发送不必要的客户端通信。

由索引模型根据 Issue 内容生成。

描述

Hyperspec uses the Filecache gem, which uses Time.now. But if Timecop freezes time in a spec, then Time.now is not returning the system time, and the Filecache does not work. This should be fixable by wrapping calls to the Filecache with the timecop return method (and a block.) But this does not in general work because Hyperspec tries to communicate the "return" to the client, even if the client is not running.

The following series of patches fixes the issue, and can be incorporated into the next point release:

module HyperSpec
  module Internal
    module Controller
      class << self
        # wrap all calls with Timecop.return so the file cache gets the true system time
        def cache_read(key)
          Timecop.return { file_cache.get(key) }
        end

        def cache_write(key, value)
          Timecop.return { file_cache.set(key, value) }
        end

        def cache_delete(key)
          Timecop.return { file_cache.delete(key) }
        rescue StandardError
          nil
        end
      end
    end
  end
end

class Lolex
  # store all lolex updates unless hyper_spec is mounted
  def self.evaluate_ruby(&block)
    if @capybara_page&.instance_variable_get('@hyper_spec_mounted')
      @capybara_page.internal_evaluate_ruby(yield)
    else
      pending_evaluations << block
    end
  end
end

主要语言: JavaScript
星标: 538
派生: 41
PR 合并指标: 30 天内没有已合并 PR