every and each unmounting...
还没有人认领这个 Issue。
评估
调研方向
从 Observable 的 AutoUnmount 行为以及 issue 中提到的 Browser::Interval 和 Browser::Delay 类开始。检查 every、each、every! 和 each! 当前如何处理卸载,然后确定应实现所提议的哪些语义以及哪种 override 行为。选定的计时器生命周期行为保持一致,并由项目的相关测试覆盖,即视为完成。
由索引模型根据 Issue 内容生成。
描述
every makes sense, as the timer will keep running for ever. But should any each timer that is still running when things unmount also be unmounted? Note that Observable includes AutoUnmount, so any store will get this behavior as well!
Then, on the other hand, there is an each! and every! method (they don't auto start, so you have to say each!(x).start. Neither of these timers IS auto-unmounted.
Couple of options:
- just take after out of unmount, and forgettabout it.
- 1 + provide a remove_after_timers method callable in Observable
- leave it, and if you want a timer that isn't unmounted use the bang variation.
- provide auto_unmount(x) attached to the timers so you say:
after(12).auto_unmount(true)orevery(12).auto_unmount(false)to override the defaults.
Currently I think its best to make both every and every! behave the same, and make each and each! not autounmount, and then add the auto_unmount method to the Browser::Interval and Browser::Delay classes.
attr_accessor :mount_point
def auto_unmount(yes)
# warning message and return if mount_point is nil
if yes
AutoUnmount.objects_to_unmount[mount_point] << self
else
AutoUnmount.objects_to_unmount[mount_point].delete(self)
end
end
alias unmount abort
now all the automounter does is set mount_point
def every!(*args, &block)
super.tap do |id|
next id if unmounted?
id.mount_point = self
id.auto_unmount(true)
end
end
def after!(*args, &block)
super.tap { |id| id.mount_point = self unless unmounted? }
end
- 主要语言
- JavaScript
- 星标
- 538
- 派生
- 41
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
hyperstack-org/hyperstack 的其他 Issue
-
enhancement needs doc
难度 2/5 1-3 小时 新手友好度 68/100
hyperstack-org/hyperstack#359 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
hyperstack-org/hyperstack#267 ·
-
难度 5/5 一周以上 新手友好度 25/100
hyperstack-org/hyperstack#457 ·
-
难度 3/5 1-2 天 新手友好度 35/100
hyperstack-org/hyperstack#456 ·
-
难度 5/5 一周以上 新手友好度 15/100
hyperstack-org/hyperstack#455 · 2 条评论 ·
查看 hyperstack-org/hyperstack 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
palladius/rails8-app-on-gcp#145 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
dotenvx/dotenv-vscode#139 ·
-
test-change-proposal
难度 2/5 1-3 小时 新手友好度 65/100
web-platform-tests/interop#1455 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
corsairdev/corsair#1764 ·
-
难度 2/5 1-3 小时 新手友好度 75/100