Allow `on_client` and related methods to be run in RSpec before(:all) blocks
还没有人认领这个 Issue。
评估
调研方向
首先跟踪现有的 RSpec 对 before_mount 的处理,然后比较在 before(:all) 中 page 不可用时 on_client、mount 和 isomorphic 的行为。完成的标准是:这些调用会根据 no_reset 被排队,并执行一次或按每个 spec 执行,同时也覆盖提议的 spec-block 形式。
由索引模型根据 Issue 内容生成。
描述
ATM if you run on_client, mount and isomorphic methods in before(:all) blocks they just don't do anything, because the capybara page is not loaded yet.
What should happen is that the args to those methods should be queued up and added in a mechanism similar what before_mount uses.
A note (that also applies to before_mount) is that if no_reset is false, then this action should repeat on each spec, but if no_reset is true, then it should only happen once.
before(:all) do
on_client do
puts 'hello world'
end
end
if no_reset is true, then 'hello world' will be displayed just once on the client, if no_reset is false then it will be displayed as each spec runs.
NOW... given all this, it would seem that what we really want to do is also make these methods (and before_mount) all available at the spec block level, which would mean that they run in a before(:all) block. So the above could be shortened to
on_client do # before(:all) is implicit
puts 'hello world'
end
- 主要语言
- JavaScript
- 星标
- 538
- 派生
- 41
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
hyperstack-org/hyperstack 的其他 Issue
-
enhancement needs doc
难度 2/5 1-3 小时 新手友好度 68/100
hyperstack-org/hyperstack#359 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
hyperstack-org/hyperstack#267 ·
-
难度 5/5 一周以上 新手友好度 25/100
hyperstack-org/hyperstack#457 ·
-
难度 3/5 1-2 天 新手友好度 35/100
hyperstack-org/hyperstack#456 ·
-
难度 5/5 一周以上 新手友好度 15/100
hyperstack-org/hyperstack#455 · 2 条评论 ·
查看 hyperstack-org/hyperstack 的全部 Issue
相似的 Issue
-
bug customer-eng Durable Agents Inngest status: needs triage
难度 2/5 1-3 小时 新手友好度 82/100
-
optimization optimization:agents-md-curator
难度 2/5 1-3 小时 新手友好度 75/100
githubnext/gh-aw-cao#13475 ·
-
[BUG]: "Clear All" in Settings doesn't clear the saved analysis, old data comes back after reload 未关闭bug
难度 2/5 1-3 小时 新手友好度 88/100
AOSSIE-Org/OrgExplorer#253 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 88/100
oxc-project/oxc#26944 ·
-
ai-observability bug team/ai-observability
难度 2/5 1-3 小时 新手友好度 78/100