Consider replacing pickle serializer with a user-provided fallback serializer

未关闭
#363 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
30/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
python

调研方向

首先跟踪客户端的备用序列化器行为,以及用户可以如何提供序列化器。明确类无法编码时的预期行为,包括 MyClass 示例,以及将 pickle 作为可选备用方案。选定的配置和失败行为均已定义,并由相关测试覆盖,即视为完成。

由索引模型根据 Issue 内容生成。

描述

Source: Internal Type: Enhancement

Pickle is currently used as the fallback serializer in the client. It is very convenient, but at the same time dangerous and causes surprising behavior.

First of all, Pickle is dangerous, since it is easy to be abuse it to execute arbitrary code. There are a many articles on the internet about that issue, such as this one: https://intoli.com/blog/dangerous-pickles/

Pickling data provides a false sense of "everything works OK" feeling. Although pickled data can only be deserialized on Python and if and only if all the classes present in pickled data are imported beforehand.

Consider the following example:

# module1/module2.py
class MyClass:
    def __init__(self, value):
        self.value = value
hz = HazelcastClient()
m = hz.get_map("mymap").blocking()
m.put("myobj", MyClass("foo"))

Since no serializer was assigned to MyClass fallback pickle serializer will be used. There are no warnings after m.put operation that the object can only be deserialized with Python code which also imports module.module2.MyClass beforehand.

I think a better way to handle this situation is, defaulting to no fallback serializer and providing the option to the user to specify it manually. So, if a class cannot be encoded we just raise an exception unless the user provided a fallback serializer (which could be pickle!).

主要语言
Python
星标
115
派生
78
平均合并
2 天 23 小时
30 天内合并 PR
2

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

hazelcast/hazelcast-python-client 的其他 Issue

查看 hazelcast/hazelcast-python-client 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。