Add support for `addLocalChild`
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- haskell
调研方向
首先阅读 Control/Distributed/Process/Registry.hs 和 Unsafe 模块，然后跟踪 startSup API 以及现有的子进程启动/重启例程。确定如何让本地子进程规范保持不可序列化，同时不影响普通监督或远程监督。完成的标准是：addLocalChild 能够用于嵌套的本地监督，并且现有的可序列化 supervisor 配置和远程监督组仍然可用。
由索引模型根据 Issue 内容生成。
描述
As per https://github.com/haskell-distributed/distributed-process-registry/blob/master/src/Control/Distributed/Process/Registry.hs, we can pass unserialisable thunks to a supervisor on the same local node, by creating a binary shim to hold the data, and creating a binary instance that simply errors on read and write.
Since the Unsafe module deliberately avoids forcing evaluation of messages, this enables us to safely pass a Process () to a local supervisor, for the purposes of adding it after initialisation.
There are some issues to be observed about this approach...
Firstly, if we wish to add children in this fashion, we might not want to support putting them in the initialisation config for the supervisor. Supporting that notion would make the init config non-serialisable.
We also need to consider whether refactoring the whole code base for this feature is worth it. Perhaps the simplest option that occurs to me, would be to store unclosured child start procs in a map, against the child keys, and when adding a local child, to ignore the closure field and just add the passed proc. So long as code which usually accesses the closure (i.e. The start/restart routines) always checks the map first, this should work fine, with minimal impact.
It could be useful to add an alternate startSup API, that takes LocalChildSpec records instead of the serialisable ones, which should allow for library users to clearly distinguish between supervisors that can be used locally and those which may be deployed to remote nodes. This would get around the issue of having non-serialisable init config.
An interesting issue here is that of nested supervision trees. If a local child spec is for a supervisor, that local child init could indeed contain non-serialisable local child specs, or regular specs.
This change would be incompatible with remote supervision groups, like those that rabbitmq uses to handle load balancing process groups. It would not prevent ordinary supervisor configurationa from being used in those kind of scenarios though...
- 主要语言
- Haskell
- 星标
- 753
- 派生
- 101
- 平均合并
- 1 天 3 小时
- 30 天内合并 PR
- 4
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
haskell-distributed/distributed-process 的其他 Issue
-
enhancement Feature Request
难度 5/5 一周以上 新手友好度 25/100
haskell-distributed/distributed-process#486 · 1 条评论 · 1 个 reaction ·
-
discuss enhancement Feature Request
难度 5/5 一周以上 新手友好度 25/100
haskell-distributed/distributed-process#478 · 4 条评论 · 3 个 reaction ·
-
enhancement Feature Request
难度 5/5 一周以上 新手友好度 15/100
haskell-distributed/distributed-process#476 · 2 个 reaction ·
-
Demonstrating the use of Cloud Haskell for a Raft implementation可能重新可做 @LaurentRDC 于 483 天前认领，目前没有进行中的 PR。 未关闭enhancement Feature Request
haskell-distributed/distributed-process#475 · 3 个 reaction · 已指派 1 人 ·
-
难度 4/5 3-5 天 新手友好度 20/100
haskell-distributed/distributed-process#473 · 4 条评论 · 1 个 reaction ·
查看 haskell-distributed/distributed-process 的全部 Issue
相似的 Issue
-
MorphRule, DataizeRule and ContextualizeRule silently accept unknown YAML keys, unlike rewrite `Rule`可能已有人在做 @renyamamoto2026-cmyk 于 1 天前认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 78/100
objectionary/phino#2107 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
维护者通常 1 天内回复