Support for Non-401 Error Codes from the validateFunc

未关闭
#245 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞

调研方向

首先阅读 cookie plugin 对 validateFunc 的处理,并将其与 issue 中描述的 @hapi/basic validate 行为进行比较。完成的标准是:对于对请求区域无效的 cookie,validation 可以返回非 401 的 Boom 错误,例如 403 Forbidden,并且有覆盖响应状态的测试。

由索引模型根据 Issue 内容生成。

描述

feature
Support plan
  • is this issue currently blocking your project? (yes/no): No
  • is this issue affecting a production system? (yes/no): No
Context
  • node version: v14.17.0
  • module version: 11.0.2
  • environment (e.g. node, browser, native): Node
  • used with (e.g. hapi application, another framework, standalone, ...): Hapi application (Hapi version = 20.2.1)
  • any other relevant information:
What problem are you trying to solve?

I have a system that involves multiple different "regions" of authorization, I want a cookie to only be valid for one of these "regions", and I have added validation checks into the validateFunc. I would love be able to respond to the client with a 403 Forbidden when the cookie provided is for a different "region" than that which it is trying to access.

Example:
I have "regions" 1 and 2, and an authorization cookie is used for region 1, but the user is making a request to GET /region/2 I would like to be able to throw boom.forbidden(), and it set the response code to 403 instead of the plugin only throwing 401 to the user.

Do you have a new or modified API suggestion to solve the problem?

I think a solution following a similar vein as to how @hapi/basic does it where if the validateFunc throws an error(/Boom error) it replaces the default boom.unauthorized()

From the @hapi/basic API documentation for the validate function:

  • Throwing an error from this function will replace default Boom.unauthorized error
主要语言
JavaScript
星标
229
派生
99
PR 合并指标
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

hapijs/cookie 的其他 Issue

查看 hapijs/cookie 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。