ER: Blank PRs get commented on for formatting issues too
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 67/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- github-actions, javascript
调研方向
阅读 ~/github-actions/trigger-pr/check-linked-issue.js，特别是第 105 行，该行指出 pr.body 为空时会发生故障。首先检查 action 如何处理拉取请求正文，并查看 PR #8815 中链接的故障报告；使用提供的 GitHub Actions 测试指南在个人环境中运行它。完成标准是 action 能处理空白的 PR 正文，并留下预期的评论。
由索引模型根据 Issue 内容生成。
描述
Emergent Requirement - Problem
We should make sure that check-linked-issue.js can handle blank PRs as well. That code currently helps to check PRs for proper formatting to make sure an issue is linked, but it fails if the PR it is checking is blank.
Issue you discovered this emergent requirement in
- #8815
Date discovered
10-24-2026
Did you have to do something temporarily
- YES
- NO
Who was involved
@castillios
@daras-cu
What happens if this is not addressed
If a blank PR get published, the PR to check for a a properly linked issue does not leave any comment on the PR to notify the author of an issue.
Resources
- This comment outlines what that failure looks like and has links to the errors that come up: https://github.com/hackforla/website/pull/8815#discussion_r4367949963
- For testing Github Actions, refer to https://github.com/hackforla/website/issues/6537#issuecomment-2041147335, especially Tips 6, 7, and 8, if you have not already created you personal environment for testing.
- More notes on testing Gtihub Actions: How to Test GitHub Actions
- Additional Notes for GitHub Actions
Recommended Action Items
- Make a new issue
- Discuss with team
- Let a Team Lead know
Potential solutions [draft]
Issue:
- Complexity: Small (While the suggested change here only requires changing one line of code, I gave it the Complexity: Small label because it requires testing GitHub Actions.)
- Relationships: None
- Size: 0.25pt
- Fix:
in ~/github-actions/trigger-pr/check-linked-issue.js (line 105), change:
const match = pr.body.match(regex);
... to:
const match = (pr.body ?? '').match(regex);
- 主要语言
- JavaScript
- 星标
- 365
- 派生
- 872
- 平均合并
- 8 天 19 小时
- 30 天内合并 PR
- 2
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
hackforla/website 的其他 Issue
-
Complexity: See issue making label epic good first issue Issue Making: Level 1 P-Feature: Project Info and Page Ready for Prioritization role: back end/devOps role: front end size: 0.25pt time sensitive
难度 1/5 1 小时以内 新手友好度 62/100
维护者通常 1 天内回复
-
Complexity: Small ER Feature: Refactor GHA Issue Making: Level 2 ready for merge team role: back end/devOps size: 0.25pt
难度 2/5 1-3 小时 新手友好度 76/100
hackforla/website#8870 · 1 条评论 ·
维护者通常 1 天内回复
-
Complexity: Small P-Feature: Project Info and Page ready for merge team role: back end/devOps role: front end size: 0.25pt time sensitive
难度 1/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
Complexity: Small ER Feature: Refactor CSS Issue Making: Level 2 P-Feature: Projects page ready for merge team role: front end size: 0.25pt
难度 2/5 1-3 小时 新手友好度 75/100
hackforla/website#8860 · 1 条评论 ·
维护者通常 1 天内回复
-
good first issue P-Feature: Project Info and Page Ready for Prioritization role: back end/devOps role: front end size: 0.25pt
难度 1/5 1 小时以内 新手友好度 78/100
维护者通常 1 天内回复
查看 hackforla/website 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
documentation
难度 1/5 1-3 小时 新手友好度 85/100
githubnext/gh-aw-workshop#5752 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 70/100
维护者通常 1 天内回复
-
channels:add check:passed
难度 1/5 1 小时以内 新手友好度 66/100
iptv-org/database#39416 · 2 条评论 ·
维护者通常 2 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
swisstopo/topo-swisseobrowser#48 ·
维护者通常 1 天内回复