Use the Markdown syntax tree for inline formatting in markup mode

未关闭
#1,265 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@d3m1d0v 已经在做这个了。

开始于 2026年10月1日。

  • #1313 来自 @d3m1d0v —— 未关闭

评估

难度
5/5
预计耗时
一周以上
新手友好度
15/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
停滞
技术栈
markdown, typescript
领域
frontend

调研方向

The issue asks to replace the text-splitting inline formatting logic in markup mode with ranges built from the Markdown syntax tree, using ensureSyntaxTree from @codemirror/language. Read the current formatting command code and the Markdown language setup first, then check linked pull request #1313 before starting. Done means every listed block type and command keeps its markers intact, with tests for each case and for undo and redo.

由索引模型根据 Issue 内容生成。

描述

enhancement

Inline formatting currently splits selections at blank lines and checks markers at range edges. It does not use the Markdown structure.

This can place formatting markers around block syntax, mix markers from separate elements, or produce invalid Markdown.

Examples:

  • List markers become part of bold or italic text.
  • Heading markers lose their meaning.
  • A selection across table cells can wrap table separators.
  • Code content can receive formatting markers as literal text.
  • Existing nested formatting can be detected incorrectly.

Proposed solution:
Use ensureSyntaxTree from @codemirror/language to read the existing Markdown syntax tree and build formatting ranges from syntax nodes.

Expected behavior:

  • Format text in each paragraph, list item, heading, or table cell separately.
  • Keep list markers, heading markers, quote prefixes, table separators, and code fences intact.
  • Support nested blocks, task lists, and multiline text.
  • Define handling for inline code, fenced code, and indented code. Formatting must not silently change literal code content.
  • Check which YFM blocks the existing parser supports and define a fallback for unsupported syntax.
  • Use syntax nodes to detect existing formatting where possible.
  • Preserve partial selections, selection direction, multiple selections, and cursor placement.
  • Keep formatting markers selected so users can apply several styles in sequence.
  • Apply each command as one undoable transaction.
  • Do not apply changes based on an incomplete syntax tree.

Apply the shared range logic to text styles, text color, inline math, and inline code. Keep command-specific rules where needed.

Add tests for each block type, mixed selections across blocks, nested formatting, consecutive commands, undo, and redo. Test states must use the same Markdown language configuration as the editor.

主要语言
TypeScript
星标
428
派生
48
平均合并
5 天 15 小时
30 天内合并 PR
47

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

gravity-ui/markdown-editor 的其他 Issue

查看 gravity-ui/markdown-editor 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。