Exception traceback disappears when running middleware
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- python
调研方向
从 graphql/execution/executor.py 第 529 行附近开始，沿着 promise rejection 路径跟踪到 complete_value_catching_error。复现所提供的 schema 和 middleware 示例，并比较有 middleware 和无 middleware 时的执行情况。完成标准是：有 middleware 的情况能够保留并记录 resolver traceback，而不只是 GraphQLLocatedError。
由索引模型根据 Issue 内容生成。
描述
Here's a small example that illustrates the issue:
import logging
import graphene
logging.basicConfig()
class Query(graphene.ObjectType):
hello = graphene.String()
def resolve_hello(self, info):
raise Exception('error')
return 'Hello'
schema = graphene.Schema(query=Query)
def middleware(next, root, info, **kwargs):
return next(root, info, **kwargs)
If we execute a query without any middleware, we get the traceback:
In [3]: schema.execute('{ hello }')
ERROR:graphql.execution.executor:An error occurred while resolving field Query.hello
Traceback (most recent call last):
File "/home/felipe/.local/share/virtualenvs/graphene-hello-viSdSxbU/local/lib/python2.7/site-packages/graphql/execution/executor.py", line 447, in resolve_or_error
return executor.execute(resolve_fn, source, info, **args)
File "/home/felipe/.local/share/virtualenvs/graphene-hello-viSdSxbU/local/lib/python2.7/site-packages/graphql/execution/executors/sync.py", line 16, in execute
return fn(*args, **kwargs)
File "<ipython-input-1-89a125ef67fc>", line 12, in resolve_hello
raise Exception('error')
Exception: error
ERROR:graphql.execution.utils:Traceback (most recent call last):
File "/home/felipe/.local/share/virtualenvs/graphene-hello-viSdSxbU/local/lib/python2.7/site-packages/graphql/execution/executor.py", line 447, in resolve_or_error
return executor.execute(resolve_fn, source, info, **args)
File "/home/felipe/.local/share/virtualenvs/graphene-hello-viSdSxbU/local/lib/python2.7/site-packages/graphql/execution/executors/sync.py", line 16, in execute
return fn(*args, **kwargs)
File "<ipython-input-1-89a125ef67fc>", line 12, in resolve_hello
raise Exception('error')
GraphQLLocatedError: error
But if we run it with the middleware, we get very little information:
In [4]: schema.execute('{ hello }', middleware=[middleware])
ERROR:graphql.execution.utils:GraphQLLocatedError: error
While investigating the issue, it looks like the point the traceback gets lost is around https://github.com/graphql-python/graphql-core/blob/master/graphql/execution/executor.py#L529. The promise gets rejected because of the exception, and then the is_reject handler returns another promise that gets immediately rejected. This new error has no traceback, so it doesn't get logged when it's caught inside complete_value_catching_error.
- 主要语言
- Python
- 星标
- 371
- 派生
- 174
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
graphql-python/graphql-core-legacy 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
-
Quiver source未关闭
难度 5/5 一周以上 新手友好度 20/100
graphql-python/graphql-core-legacy#286 · 3 个 reaction ·
-
难度 4/5 3-5 天 新手友好度 35/100
-
难度 3/5 1-2 天 新手友好度 35/100
graphql-python/graphql-core-legacy#280 · 2 条评论 · 1 个 reaction ·
-
Add support for custom validators in default GraphQL backend可能已有人在做 @JoaRiski 于 2424 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 35/100
查看 graphql-python/graphql-core-legacy 的全部 Issue
相似的 Issue
-
documentation good first issue
难度 2/5 半天 新手友好度 72/100
sujithputta02/Esapay#13 ·
-
bug
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
needs-triage
难度 2/5 1-3 小时 新手友好度 72/100
gke-labs/kube-agents#3277 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
jbacalso24/mimry#291 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 1 小时以内 新手友好度 82/100
eli-alvarado/us-watchlist-alerts#14 ·
维护者通常 1 天内回复