Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Circular import solution

未关闭
#1,309 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
python
领域
api

调研方向

首先检查 graphene/types/schema.py 中 construct_fields_for_type 附近的代码以及 utils 中的 get_type/import_string 方法,然后复现链接讨论中的循环导入示例。完成的标准是确定传入 schema 是否能解决该示例,同时不破坏现有的类型解析,并记录最终的决定。

由索引模型根据 Issue 内容生成。

描述

✨ enhancement

I would like to contribute a solution to the circular import problem. As far as I can see, currently this problem has some workaround through the Dynamic type:
https://github.com/graphql-python/graphene/issues/522#issuecomment-626075061

From my point of view strategy described in this link is pretty much elegant, since it uses type argument from Scheme constructor, which has relevant description:

types (List[GraphQLType], optional): List of any types to include in schema that
            may not be introspected through root types.

But instead of creating new types and making syntax even more complicated and non-readable, I would like to propose a solution with schema pushing down to the import_string method from utils.
Apparently, it was not difficult task:

I made fast and simple changes in interfaces, in order to do this:

Changed type method interface of Field class:

    def type(self, schema):
        return get_type(self._type, schema)

Then reducer invocation here :

    def construct_fields_for_type(self, map, type, is_input_type=False):
        fields = OrderedDict()
        for name, field in type._meta.fields.items():
            if isinstance(field, Dynamic):
                field = get_field_as(field.get_type(self.schema), _as=Field)
                if not field:
                    continue
            map = self.reducer(map, field.type(self.schema))
            field_type = self.get_field_type(map, field.type(self.schema))

Small changes for get_type method:

def get_type(_type, schema=None):
    if isinstance(_type, string_types):
        return import_string(_type, schema=schema)
def import_string(type_name, dotted_attributes=None, schema=None):
    if schema:
        try:
            scheme_type = next(type_ for type_ in schema.types if type_._meta.name == type_name)
            return scheme_type
        except StopIteration:
            pass
   ....

At the end of a day I was able to run code from link without problems.

from graphene import ObjectType, List


class FooBarBaz(ObjectType):
    foo_bars = List('FooBar', required= True)

It is a small fix, I made them with respect to my first impression of graphene structure.

Please, give me feedback, if this solution is okay for you, I will make a pull request.
If not, please, describe why and how can I then avoid circular import

主要语言
Python
星标
8.2k
派生
818
PR 合并指标
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

graphql-python/graphene 的其他 Issue

查看 graphql-python/graphene 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。