Directive wirings see a type reference on recursive input fields
维护者通常 1 天内回复
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
调研方向
Start by comparing this schema's directive wiring during type construction with graphql-java's SchemaGenerator behavior described in the issue; the issue names no source files or tests. Reproduce the recursive Tree input case and confirm the GraphQLTypeReference seen for and. Done means directive wiring runs after schema assembly and recursive fields expose the resolved input type across the affected object, interface, union, enum, and input object cases.
由索引模型根据 Issue 内容生成。
描述
A SchemaDirectiveWiring that looks at the type of a recursive input field gets a GraphQLTypeReference instead of the input object:
directive @check on INPUT_FIELD_DEFINITION
type Query {
trees(filter: Tree): Int
}
input Tree {
and: [Tree!] @check
name: String @check
}
In onInputObjectField, GraphQLTypeUtil.unwrapAll(element.type) is a GraphQLTypeReference for and (name is a GraphQLScalarType as expected). The same schema and wiring through plain graphql-java's SchemaGenerator gives a GraphQLInputObjectType for and.
So any wiring that walks input types and calls unwrapAll fails with ClassCastException: GraphQLTypeReference cannot be cast to GraphQLUnmodifiedType. I believe that includes graphql-java-extended-validation's DirectivesAndTypeWalker, but I haven't run it against this schema.
#843 fixed the non-recursive case (input objects behind a list or non-null wrapper) and left cycles out. Types are immutable, so one field of a cycle has to stay a reference while the type is being built. graphql-java only runs directive wirings once the whole schema is assembled, so its wirings never see that reference. Ours run while types are being built, so they do.
The fix is probably to hold off all directive wiring until the schema is assembled. That touches objects, interfaces, unions and enums too, not just input objects. I haven't prototyped it.
Not the same as #36 or #450. Those were about recursive inputs not building at all, and that's fixed.
- 主要语言
- Kotlin
- 星标
- 824
- 派生
- 175
- 平均合并
- 2 天 5 小时
- 30 天内合并 PR
- 52
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
graphql-java-kickstart/graphql-java-tools 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 85/100
graphql-java-kickstart/graphql-java-tools#893 ·
维护者通常 1 天内回复
-
bug
难度 3/5 1-2 天 新手友好度 74/100
graphql-java-kickstart/graphql-java-tools#896 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 72/100
graphql-java-kickstart/graphql-java-tools#889 ·
维护者通常 1 天内回复
-
bug
难度 3/5 1-2 天 新手友好度 55/100
graphql-java-kickstart/graphql-java-tools#886 ·
维护者通常 1 天内回复
-
enhancement
难度 3/5 1-2 天 新手友好度 72/100
graphql-java-kickstart/graphql-java-tools#884 ·
维护者通常 1 天内回复
查看 graphql-java-kickstart/graphql-java-tools 的全部 Issue
相似的 Issue
-
enhancement impact:U1 P3 reach:R2 size:S
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 73/100
ankidroid/Anki-Android#22677 ·
维护者通常 1 天内回复
-
Type Pick Request
难度 2/5 1-3 小时 新手友好度 68/100
reactwg/react-native-releases#1456 · 1 条评论 ·
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
yschimke/homeassistant-remotecompose#1038 ·
维护者通常 1 天内回复
-
area:data-quality importer size:S
难度 2/5 1-3 小时 新手友好度 84/100
enorm-labs/event-junkie#3707 ·
维护者通常 1 天内回复