Let the mail transport be chosen instead of hardcoded

未关闭
#116 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
18/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
冷清
技术栈
go
领域
backend

调研方向

Start in buildMailSender in cmd/alphone/mail.go (around line 33), which calls smtp.New unconditionally, then read how wireFieldProviders and wireCredentialProviders in cmd/alphone/run.go collect from plugins. The sdk's MailSenderConsumer is the existing plugin-facing type, and the issue says no reverse seam exists yet. Done would mean transport selection comes from configuration and a provider seam exists, but the issue does not define the seam's shape or name a test, so agree on the design with maintainers first.

由索引模型根据 Issue 内容生成。

描述

Only one mail transport can ever run, because the composition root names it directly. A second transport is unreachable wherever its code lives.

Current state: buildMailSender in cmd/alphone/mail.go:33 calls smtp.New unconditionally, and the only choice is whether an SMTP host is set. Settings are read once from the environment at boot. The sdk declares MailSenderConsumer, which hands a sender down to plugins, and no seam pointing the other way, although wireFieldProviders and wireCredentialProviders in cmd/alphone/run.go already collect from plugins that way.

Proposal: pick the transport from configuration first, and add the missing provider seam. A selector in the settings screen follows once settings move to a table.

Trigger: before a second transport ships.

主要语言
Go
星标
287
派生
64
平均合并
13 小时 36 分钟
30 天内合并 PR
64

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

gopherium/AlphOne 的其他 Issue

查看 gopherium/AlphOne 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。