solutions/automations/vacation-calendar/ fails to import events that are created too far in advance
@vinay-google 已经在做这个了。
开始于 2024年7月10日。
评估
这个 Issue 还没有评估数据。
描述
Summary
The code in solutions/automations/vacation-calendar/Code.js uses lastRun to constrain the event search, but only imports events that are timed between now and MONTHS_IN_ADVANCE months from now.
Hence, these events never get imported because when they satisfy the updatedMin parameter constraint in the Calendar.Events.list call, they fail the timeMin and timeMax constraint.
Expected Behavior
The code would import events, even events created a long time ago, if they occur within the search period (now, now+MONTHS_IN_ADVANCE).
Sample URL: https://github.com/googleworkspace/apps-script-samples/blob/main/solutions/automations/vacation-calendar/Code.js
Description:
Actual Behavior
The code only imports events if they were created within MONTHS_IN_ADVANCE of their occurrence. Other events are skipped entirely.
Steps to Reproduce the Problem
- Create a vacation event for a date 4 months from now.
- Let the script run.
- Notice that the event is not imported and is never imported.
Proposal
While the optSince parameter in findEvents is useful in further demonstrating the Calendar.Events.list API call, and generally reduces execution cost, it seems to prevent one important expected behavior for a team vacation populator---that events planned far in advance will show up in the team calendar. I suggest three alternatives:
- Remove the
updatedMinparameter in thefindEventsbody. That way, the code will still add upcoming events, but will add redundant events that get de-duplicated. - Set the default MONTHS_IN_ADVANCE relatively large, e.g., 12, 18 or more, so that the problem only manifests for events created much farther in advance.
- Add a warning comment in the code that alerts the developer to the nature of these skipped imports and let the developer implement solution if desired.
- 主要语言
- JavaScript
- 星标
- 5.2k
- 派生
- 2k
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
googleworkspace/apps-script-samples 的其他 Issue
-
难度 5/5 一周以上 新手友好度 1/100
googleworkspace/apps-script-samples#659 · 1 条评论 · 1 个 reaction ·
-
Password reset未关闭
难度 5/5 一周以上 新手友好度 15/100
googleworkspace/apps-script-samples#654 · 2 个 reaction ·
-
cod gs未关闭
难度 5/5 一周以上 新手友好度 10/100
googleworkspace/apps-script-samples#651 · 1 个 reaction ·
-
tespogrome未关闭
难度 5/5 一周以上 新手友好度 1/100
googleworkspace/apps-script-samples#624 · 1 个 reaction ·
-
Get_order_manually.gs可能重新可做 @vinay-google 于 243 天前认领，目前没有进行中的 PR。 未关闭
googleworkspace/apps-script-samples#616 · 已指派 1 人 ·
查看 googleworkspace/apps-script-samples 的全部 Issue
相似的 Issue
-
Access-request approve silently discards the decider's note (decision_note written only on deny)未关闭bug
难度 2/5 1-3 小时 新手友好度 72/100
Uuriko/project-room#3378 ·
维护者通常 1 天内回复
-
Notifications pagination accepts NaN and negative LIMIT/OFFSET可能已有人在做 @Senthil455 今天认领。 未关闭BUGS MEDIUM
难度 2/5 1-3 小时 新手友好度 62/100
elixpo/blogs.elixpo#419 · 2 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 65/100
immich-app/immich#32426 ·
维护者通常 1 天内回复