Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

cleanup(storage): remove disable_deprecation_warnings.inc headers once deprecated checksum options are removed

未关闭
  • 哪里不对？
#16,545 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
cpp
领域
backend

调研方向

Start by checking issue #16404 to confirm the deprecated checksum and hashing symbols have been removed; this cleanup depends on that work. Then inspect the listed Cloud Storage headers and implementation files for disable_deprecation_warnings.inc and, in signed_url_requests.h, diagnostics_pop.inc. Remove the suppression includes once no deprecated symbols remain, and verify the relevant Bazel builds no longer need them.

由索引模型根据 Issue 内容生成。

描述

api: storage type: cleanup

Summary

Several Cloud Storage headers and implementation files include google/cloud/internal/disable_deprecation_warnings.inc (and google/cloud/internal/diagnostics_pop.inc in headers) to suppress -Wdeprecated-declarations compiler warnings while maintaining backward compatibility for deprecated checksum/hashing options.

Once the deprecated checksum/hashing symbols (MD5HashValue, Crc32cChecksumValue, UseCrc32cValueOption, UseMD5ValueOption, EnableCrc32cValidationOption, EnableMD5ValidationOption, DisableMD5Hash, DisableCrc32cChecksum) are removed from the codebase (see #16404), remove these .inc diagnostic suppression headers.

Background

  • PR #16311 formally deprecated MD5HashValue, Crc32cChecksumValue, UseCrc32cValueOption, and UseMD5ValueOption in favor of PrecomputedChecksumsOption (and EnableCrc32cValidationOption / EnableMD5ValidationOption / DisableCrc32cChecksum / DisableMD5Hash in favor of UploadChecksumValidationOption and DownloadChecksumValidationOption).
  • To prevent -Wdeprecated-declarations warnings in Bazel builds while continuing to honor these deprecated options internally, disable_deprecation_warnings.inc (and diagnostics_pop.inc) was added to internal headers and implementation files.

Affected Files

Files updated to suppress deprecation diagnostics for internal backward-compatibility plumbing:

  • google/cloud/storage/internal/signed_url_requests.h (disable_deprecation_warnings.inc and diagnostics_pop.inc)
  • google/cloud/storage/parallel_upload.cc
  • google/cloud/storage/internal/async/writer_connection_impl.cc
  • google/cloud/storage/internal/async/connection_impl.cc
  • google/cloud/storage/internal/async/default_options.cc

Additional google/cloud/storage/ files containing disable_deprecation_warnings.inc for deprecated checksum options (see also #16404):

  • google/cloud/storage/hashing_options.h
  • google/cloud/storage/parallel_upload.h
  • google/cloud/storage/client.cc
  • google/cloud/storage/internal/async/checksum_helpers.h
  • google/cloud/storage/internal/checksum_helpers.h
  • google/cloud/storage/internal/connection_impl.cc
  • google/cloud/storage/internal/grpc/stub.cc
  • google/cloud/storage/internal/hash_function.h
  • google/cloud/storage/internal/hash_function.cc
  • google/cloud/storage/internal/hash_validator.cc
  • google/cloud/storage/internal/object_requests.h
  • google/cloud/storage/internal/object_requests.cc
  • google/cloud/storage/internal/rest/stub.cc
主要语言
C++
星标
659
派生
471
平均合并
1 天 10 小时
30 天内合并 PR
100

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

googleapis/google-cloud-cpp 的其他 Issue

查看 googleapis/google-cloud-cpp 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。