Bare list/dict annotations leave GoogleAdsClient.get_service and generated request params partially unknown
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 74/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- grpc, python
调研方向
Start with google/ads/googleads/client.py and the ads generator client.py.j2 template named in the issue, then reproduce the strict pyright diagnostics with the provided example. Update the annotations at both locations and verify that get_service and generated request parameters no longer produce partially unknown types; the issue describes these as annotation-only changes with no runtime effect.
由索引模型根据 Issue 内容生成。
描述
With google-ads 31.0.0 under pyright strict, two annotations without type arguments make every call site report reportUnknownMemberType:
GoogleAdsClient.get_service(..., interceptors: Union[list, None] = None, ...)ingoogle/ads/googleads/client.py.list[grpc.UnaryUnaryClientInterceptor]orSequence[...]would type it.- Every generated service method:
request: Optional[Union[<Request>, dict]] = None, for exampleConversionUploadServiceClient.upload_click_conversions. This comes from the ads generator template (packages/gapic-generator/gapic/ads-templates/.../client.py.j2in googleapis/google-cloud-python).Dict[str, Any]would type it.
Repro:
from google.ads.googleads.client import GoogleAdsClient
from google.ads.googleads.v24.services.services.conversion_upload_service import ConversionUploadServiceClient
def f(c: GoogleAdsClient, s: ConversionUploadServiceClient) -> None:
c.get_service("ConversionUploadService") # Type of "get_service" is partially unknown
s.upload_click_conversions(request=None) # Type of "upload_click_conversions" is partially unknown
These are annotation-only changes with no runtime effect. Callers currently work around them with local Protocols.
- 主要语言
- Python
- 星标
- 754
- 派生
- 550
- 平均合并
- 27 分钟
- 30 天内合并 PR
- 1
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
googleads/google-ads-python 的其他 Issue
-
Package license info is non-conformant with modern standards可能已有人在做 @BenRKarl 于 96 天前认领。 未关闭bug triage
googleads/google-ads-python#1081 · 5 条评论 · 已指派 1 人 ·
查看 googleads/google-ads-python 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
huggingface/smolagents#2976 ·
维护者通常 1 天内回复
-
bug Triage-Needed
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
FuRongJun-1999/dsh-memory#170 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
pgvector/pgvector-python#163 ·
-
难度 1/5 1 小时以内 新手友好度 82/100
521xueweihan/HelloGitHub#3940 ·