Prebuilt-cache errors tell framework integrations to run `bin/aspect cache:warmup:aop`: make the rebuild hint configurable

未关闭
  • 哪里不对？
#840 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
php
领域
backend-api-design

调研方向

Start with the three factory methods in src/Aop/Exception/WeavingException.php named in the issue and trace how integrations can provide a rebuild command. Add a unit test confirming the messages contain the configured command. Done when all three messages use that command and composer test and composer analyse pass; integration follow-ups are listed separately.

由索引模型根据 Issue 内容生成。

描述

Enhancement

Found while building goaop/shop-demo-laravel and goaop/shop-demo-symfony (framework 4.0.0). Related: goaop/goaop-symfony-bundle#50.

Problem

Three exceptions of src/Aop/Exception/WeavingException.php end with the same hint: rebuild it with bin/aspect cache:warmup:aop. They are:

  • prebuiltCacheVersionMismatch(), :85-92;
  • sourceMissingFromPrebuiltCache(), :102-110;
  • the missing-cached-file variant, :119.

In the integrations that command doesn't exist or doesn't apply:

  • Laravel (goaop-laravel-bridge): php artisan aop:warmup;
  • Symfony (GoAopBundle): bin/console cache:clear (or cache:warmup), which rebuilds the container and the AOP cache together.

A Laravel user sees, for example:

Class App\Aspects\CachingAspect (...) is missing from the prebuilt AOP cache in .../storage/framework/aop:
with Features::PREBUILT_CACHE a request never weaves, so the cache is incomplete, rebuild it with `bin/aspect cache:warmup:aop`

Proposal

One static, overridable hint, set by the integrations once when their kernel is created:

// e.g. on AspectKernel (or WeavingException)
public static string $cacheRebuildCommand = 'bin/aspect cache:warmup:aop';

The three factory methods use it. GoAopBundle sets bin/console cache:clear, the Laravel bridge sets php artisan aop:warmup (or both pass it as a kernel option instead of a static).

Acceptance

  • A unit test: the messages contain the configured command.
  • Follow-ups in the bundle (goaop/goaop-symfony-bundle#50) and the bridge to set it.
  • composer test, composer analyse.
主要语言
PHP
星标
1.7k
派生
166
平均合并
23 小时 58 分钟
30 天内合并 PR
40

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

goaop/framework 的其他 Issue

查看 goaop/framework 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。