Finish native pointer delivery and validation
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 15/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- swift
调研方向
Start from the merged click, scroll and drag work in PRs #82, #70 and #85, and from the open coverage list in this issue. The remaining work is verification, not new code: worker-crash and in-flight Stop cases, self-Ace scrolling, multiple displays, and a second machine. Done means each open item has a recorded real run or an explicit note that it stays unverified, tracked in githubnext/ace2#8.
由索引模型根据 Issue 内容生成。
描述
Status (Oct 6): clicks, scrolling and atomic drag are merged (#82, githubnext/ace2#70, githubnext/ace2#85), and githubnext/ace2#156 now gives pixels-only snapshots exact-window coordinate authority for point clicks, scrolls and drags. Remaining evidence gaps: one full model workflow using githubnext/ace2#156 pixel snapshots that includes an effective drag (an earlier real pi/Anthropic run with Accessibility snapshots completed click, scroll and drop; see below), worker crash and in-flight Stop during input, self-Ace scrolling, multiple displays/negative origins/hotplug, and a second machine. Moved-window stale-click classification is githubnext/ace2#155.
Continue githubnext/ace2#8's complete-input slice with native pointer operations through Ace's embedded bridge and existing pi tools.
- Extend observed-control clicks with useful click variants and exact-window screenshot-coordinate clicks.
- Add targeted scrolling to an observed control or screenshot point, with explicit direction and bounded native scroll amount.
- Add an atomic drag with one complete press/move/release sequence, bounded duration, and cleanup on cancellation. Do not expose unowned cross-call held input.
- Resolve screenshot points through Peekaboo's stored capture coordinate authority. Account for Ace image resizing, Retina scale, multiple/negative-origin displays, and moved windows. Reject stale target identities/bounds rather than silently remapping against a new window.
- Reuse exact process/window receipts, single-use snapshots, native coordination, durable completed/refused/unknown outcomes, and the channel owner's desktop-tools setting (see githubnext/ace2#8). Make supported background versus foreground operations explicit; no silent global-input fallback.
Done when real native and pi/model workflows can click by visual coordinates, scroll to initially offscreen content, and complete a real drag-and-drop, with resulting state verified and interruption cleanup/no-replay validated. Include the hosted workspace path and clearly track unverified multi-display or second-machine behavior in githubnext/ace2#8.
Click variants and normalized screenshot-coordinate clicks landed in PR githubnext/ace2#82, merge e5618c1. Real native callbacks covered single/double/right/middle/triple behavior and resized screenshot coordinates; consumed snapshots were refused. The real pi/Anthropic check on exact PR82 head 5f98d94 performed one coordinate click with exactly one intended callback and unchanged unrelated state. Exact tool text/images and usage survived reopening the same pi store without repeated input.
Targeted scrolling landed in PR githubnext/ace2#70, merge 44312423ce66443ab38cd1ba6666bec32904e068, from reviewed head f1682d028a9f810c93c103286949c1ad69c8ef13. It accepts an observed element or normalized screenshot point, four directions, and 1–20 native units. Final types, formatting/lint, Swift parsing, diff checks, and independent source review passed. The extracted scroll implementation is unchanged from signed candidate d9b0c869; the extraction/base integration was not rebuilt into another signed app.
On that signed candidate, five real AppKit scrolls passed: element down, point down revealing previously offscreen content, element up, point right, and element left. A subsequent real pi/Anthropic run performed inspect → element up1 → inspect, moving the actual vertical origin from 2063 to 1834 while horizontal origin 68 and unrelated pointer state stayed unchanged. Exact native receipts and tool text/images survived completed-store reopen with unchanged usage and no repeated input. This does not claim worker-crash or hosted behavior.
The earlier delivered-but-unknown scroll was traced to omitted snapshot focus in the request, despite that focus being retained in the signed native receipt. The landed fix carries the original focus into scroll's expected-window target without relaxing receipt validation or coordinate authority. No uncertain input was replayed.
Atomic dragging landed in PR githubnext/ace2#85, merge 68b4a3f641858526d80de352de84260a7f3e8f5a, from reviewed head bf930584700306ec379036c320dd1c61be4f6db9. The native code is unchanged from signed candidate 2531311; final changes were tool/documentation guidance, with fresh type/lint checks. Native signatures, compilation, and independent source review passed.
Real focused left/right drags each produced one press, twenty moves and one release, moved the tile and completed the drop. Invalid endpoints/stationary gestures/durations refused without input. A new, verified window move made its fresh prior observation stale, and a drag using it refused with the receiver unchanged. Cancelling a five-second gesture only after actual mouse-down returned unknown, delivered exactly one release, and drained every native call without changing scroll position.
A real pi/Anthropic run in local Workers/Durable Objects then performed inspect → Activate click → one scroll → drag → inspect through the actual workspace adapter and signed native bridge. The fixture recorded one click, scroll from 0 to 229, and one completed tile drop. Native text and images crossed the workspace unchanged. Restarting the same persistence with the workspace offline replayed all five exact results/images with unchanged receiver state and provider usage. This is completed-run replay, not a crash during input.
The earlier inactive receiver accepted dispatch but recorded no input or movement. Separate explicit activation/focus before the successful cases establishes the supported workflow; delivery acceptance alone never proves a drop. One Retina display (native scale 2) and Ace's resized 1600×1053 image were exercised.
Remaining coverage stays open here and in githubnext/ace2#8: worker-crash/in-flight Stop cases, self-Ace scrolling, multiple displays/negative origins/hotplug, and another physical machine. Pixels-only observations could not authorize pointer actions without canonical capture authority; githubnext/ace2#156 resolved that. No broader hardware or inactive-view delivery claim is made.
- 主要语言
- Swift
- 星标
- 0
- 派生
- 0
- 平均合并
- 15 分钟
- 30 天内合并 PR
- 94
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
githubnext/desktop-tools 的其他 Issue
-
ace documentation
难度 2/5 1-3 小时 新手友好度 79/100
githubnext/desktop-tools#104 ·
维护者通常 1 天内回复
-
documentation
难度 4/5 3-5 天 新手友好度 35/100
githubnext/desktop-tools#75 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 55/100
githubnext/desktop-tools#42 · 29 条评论 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 15/100
githubnext/desktop-tools#27 · 3 条评论 ·
维护者通常 1 天内回复
-
question
难度 5/5 一周以上 新手友好度 8/100
githubnext/desktop-tools#24 ·
维护者通常 1 天内回复
查看 githubnext/desktop-tools 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 74/100
Emanuele-web04/remodex#203 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 92/100
维护者通常 1 天内回复
-
test(BrainBar): inject synthetic observabilityCadence in BackupsHealth/one-page fixtures (DCI-1)未关闭
难度 2/5 1-3 小时 新手友好度 74/100
EtanHey/brainlayer#1367 ·
维护者通常 1 天内回复
-
cmux-next: new workspaces show no name instead of workspace-N可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭area: workspaces
难度 2/5 1-3 小时 新手友好度 82/100
manaflow-ai/cmux#21357 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 4 天内回复