Lanes are never pruned after their PR merges (76 lanes / ~128 GB locally)
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- git, github, typescript
调研方向
Start with apps/host/src/manage.ts and apps/app/src/git.ts, then read packages/channel/src/lanes.ts and the lane CLI guidance in AGENTS.md. Trace how channel removal and PR state are handled, and check how git fetch --prune and lane prune report lanes they retain. Done when merged lanes are pruned by the host and retained lanes have a visible reason.
由索引模型根据 Issue 内容生成。
描述
Summary
Lanes are never removed after their PR merges. On one dev machine, ace2 had built up 76 lanes taking about 128 GB, and 59 of them belonged to PRs that had already merged. The lane lifecycle (https://lane.lukeed.com/usage/) expects lane prune to remove landed lanes. In practice, nothing in Ace runs it, and with our merge setup it can't recognise most of our lanes as landed anyway.
What's happening
1. Nothing runs lane prune.
- The only mention is in agent instructions:
AGENTS.md:71andAGENTS.md:109say to runlane prune"once it merges". - The agent's turn ends at
gh pr create. The merge happens later on GitHub, and nobody comes back afterwards. remove()inapps/host/src/manage.ts:278removes only the older worktrees kept in the channel directory, and only when a channel is deleted. Lanes created bylane neware deliberately left "forlane pruneorlane rm". Channels that are archived or simply kept retain all their lanes.
2. lane prune didn't treat our merged lanes as landed.
- Per
AGENTS.md:71, prune removes a lane once its remote branch is gone or localmaincontains its work. - Until today githubnext/ace had
delete_branch_on_merge: false, and AGENTS.md says to merge without--delete-branch, so remote branches stayed after merging. Example:fair-ember/canary-0-0-13(#115, merged Oct 5) was still on origin. - PRs are squash-merged, so
mainnever contains the lane's commits. - Lanes from before Ace adopted the lane CLI (in
~/.local/state/ace*/channels/*/lanes, created before about Oct 13) have no landing record fromlane push, so prune reportslanded outside lane. - As a result,
lane lsshowed 63 lanes aspushedand none aslanded.lane prune --dry-runlisted 6 skipped lanes and said nothing about the other 70, so they were invisible as well as kept.
Breakdown at the time:
| Kind | Count | PR status |
|---|---|---|
| Lanes in the channel directory (pre-lane CLI) | 70 | 57 merged, 2 closed, 11 never had a PR |
lane new lanes, .lane/trees |
6 | 2 closed, 4 never had a PR |
Done so far
- "Automatically delete head branches" is now on for githubnext/ace. Merges from now on should delete the remote branch, so
git fetch --prune && lane pruneought to catch them. This hasn't been verified yet on a lane that merged after the change. - One-off local cleanup: I removed 51 merged lanes from the channel directory with
git worktree remove. Each one was clean, and its HEAD equalled the merged PR'sheadRefOid.
Proposal
- Have the host run
git fetch --prune+lane pruneitself.- On host start, or periodically.
- When it sees a channel's PR become merged.
apps/app/src/git.tsalready tracks PR state. - In
remove()when a channel is deleted, instead of leaving its lanes behind.
- Surface lanes prune refuses. The
landed outside laneandcommits main does not havecases should appear somewhere visible, so they aren't left on disk indefinitely. - Retire the pre-lane-CLI path. After a one-time migration that drops merged lanes from the channel directory, the
lanesloop inremove()and therecorded?.pathfallback inpackages/channel/src/lanes.tscan go. - Possibly upstream in lane: have
lane prune --dry-runlist every lane it keeps and why, not only some of them. A lane that ispushedwith an existing remote branch is currently omitted silently.
- 主要语言
- TypeScript
- 星标
- 1
- 派生
- 0
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
githubnext/ace2 的其他 Issue
-
documentation
难度 2/5 1-3 小时 新手友好度 76/100
githubnext/ace2#530 · 1 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 88/100
githubnext/ace2#437 ·
-
难度 4/5 3-5 天 新手友好度 45/100
githubnext/ace2#528 ·
-
难度 5/5 一周以上 新手友好度 20/100
githubnext/ace2#511 ·
-
难度 5/5 一周以上 新手友好度 25/100
githubnext/ace2#506 ·
相似的 Issue
-
check:failed streams:edit
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 2 天内回复
-
package:ios ships XCFrameworks with absolute symlinks, which SwiftPM refuses to extract可能已有人在做 @cusnirvladislav 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
callstackincubator/rock#740 ·
-
S: triage
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 2 天内回复
-
area:workflow bug ready-for-human
难度 1/5 1 小时以内 新手友好度 78/100
fil-donadoni/tolaria#6108 ·
维护者通常 1 天内回复