Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Lanes are never pruned after their PR merges (76 lanes / ~128 GB locally)

未关闭
#529 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
git, github, typescript

调研方向

Start with apps/host/src/manage.ts and apps/app/src/git.ts, then read packages/channel/src/lanes.ts and the lane CLI guidance in AGENTS.md. Trace how channel removal and PR state are handled, and check how git fetch --prune and lane prune report lanes they retain. Done when merged lanes are pruned by the host and retained lanes have a visible reason.

由索引模型根据 Issue 内容生成。

描述

Summary

Lanes are never removed after their PR merges. On one dev machine, ace2 had built up 76 lanes taking about 128 GB, and 59 of them belonged to PRs that had already merged. The lane lifecycle (https://lane.lukeed.com/usage/) expects lane prune to remove landed lanes. In practice, nothing in Ace runs it, and with our merge setup it can't recognise most of our lanes as landed anyway.

What's happening

1. Nothing runs lane prune.

  • The only mention is in agent instructions: AGENTS.md:71 and AGENTS.md:109 say to run lane prune "once it merges".
  • The agent's turn ends at gh pr create. The merge happens later on GitHub, and nobody comes back afterwards.
  • remove() in apps/host/src/manage.ts:278 removes only the older worktrees kept in the channel directory, and only when a channel is deleted. Lanes created by lane new are deliberately left "for lane prune or lane rm". Channels that are archived or simply kept retain all their lanes.

2. lane prune didn't treat our merged lanes as landed.

  • Per AGENTS.md:71, prune removes a lane once its remote branch is gone or local main contains its work.
  • Until today githubnext/ace had delete_branch_on_merge: false, and AGENTS.md says to merge without --delete-branch, so remote branches stayed after merging. Example: fair-ember/canary-0-0-13 (#115, merged Oct 5) was still on origin.
  • PRs are squash-merged, so main never contains the lane's commits.
  • Lanes from before Ace adopted the lane CLI (in ~/.local/state/ace*/channels/*/lanes, created before about Oct 13) have no landing record from lane push, so prune reports landed outside lane.
  • As a result, lane ls showed 63 lanes as pushed and none as landed. lane prune --dry-run listed 6 skipped lanes and said nothing about the other 70, so they were invisible as well as kept.

Breakdown at the time:

Kind Count PR status
Lanes in the channel directory (pre-lane CLI) 70 57 merged, 2 closed, 11 never had a PR
lane new lanes, .lane/trees 6 2 closed, 4 never had a PR

Done so far

  • "Automatically delete head branches" is now on for githubnext/ace. Merges from now on should delete the remote branch, so git fetch --prune && lane prune ought to catch them. This hasn't been verified yet on a lane that merged after the change.
  • One-off local cleanup: I removed 51 merged lanes from the channel directory with git worktree remove. Each one was clean, and its HEAD equalled the merged PR's headRefOid.

Proposal

  • Have the host run git fetch --prune + lane prune itself.
    • On host start, or periodically.
    • When it sees a channel's PR become merged. apps/app/src/git.ts already tracks PR state.
    • In remove() when a channel is deleted, instead of leaving its lanes behind.
  • Surface lanes prune refuses. The landed outside lane and commits main does not have cases should appear somewhere visible, so they aren't left on disk indefinitely.
  • Retire the pre-lane-CLI path. After a one-time migration that drops merged lanes from the channel directory, the lanes loop in remove() and the recorded?.path fallback in packages/channel/src/lanes.ts can go.
  • Possibly upstream in lane: have lane prune --dry-run list every lane it keeps and why, not only some of them. A lane that is pushed with an existing remote branch is currently omitted silently.
主要语言
TypeScript
星标
1
派生
0
PR 合并指标
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

githubnext/ace2 的其他 Issue

查看 githubnext/ace2 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。