Commit-pinned actions can be reported as unresolved even when action.yml exists
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 67/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- github, typescript, vscode
调研方向
使用固定到 commit 的 workflow 重现,然后跟踪 issue 中描述的 language server action 元数据查找过程,包括 Contents API 以及捆绑的路径 dist/server-node.js 和 dist/server-web.js。比较 action.yml 和 action.yaml 的完整 SHA 处理,并验证有效的 ref 能够在没有诊断信息的情况下解析,同时正常的输入验证仍会运行。
由索引模型根据 Issue 内容生成。
描述
Summary
The GitHub Actions extension can report commit-pinned actions as unresolved even when the action repository, ref, and action.yml are valid and publicly reachable.
This affects workflows that pin actions by full commit SHA for supply-chain hardening. The workflow is valid and GitHub Actions can run it, but the VS Code Problems panel reports:
Unable to resolve action `actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd`, repository or version not found
Unable to resolve action `step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5`, repository or version not found
This is related in symptom to #143, but the failure mode is different: this is not a network timeout and not a missing tag. These are full commit SHA refs whose action.yml resolves successfully via GitHub.
Environment
- Extension:
github.vscode-github-actions0.31.5 - VS Code:
1.120.0, Windows x64 - Also reproduced in Google Antigravity
1.107.0, which uses the same extension version (github.vscode-github-actions@0.31.5) - OS: Windows
Reproduction
Create or open a workflow containing commit-pinned actions, for example:
steps:
- name: Harden the runner
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Open the workflow in VS Code with the GitHub Actions extension enabled.
Actual behavior
The Problems panel shows errors like:
Unable to resolve action `step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5`, repository or version not found
Unable to resolve action `actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd`, repository or version not found
Expected behavior
The extension should resolve action metadata for full SHA refs the same way it does for tags/branches, as long as action.yml or action.yaml exists at that ref.
At minimum, it should not emit repository or version not found when the repo/ref/action metadata file can be fetched successfully.
Evidence that the refs are valid
The tags resolve to the same commits:
$ git ls-remote --tags https://github.com/actions/checkout.git refs/tags/v6.0.2
de0fac2e4500dabe0009e67214ff5f5447ce83dd refs/tags/v6.0.2
$ git ls-remote --tags https://github.com/step-security/harden-runner.git refs/tags/v2.19.3
ab7a9404c0f3da075243ca237b5fac12c98deaa5 refs/tags/v2.19.3
The GitHub Contents API also resolves action.yml at both refs:
GET /repos/actions/checkout/contents/action.yml?ref=de0fac2e4500dabe0009e67214ff5f5447ce83dd -> 200
GET /repos/step-security/harden-runner/contents/action.yml?ref=ab7a9404c0f3da075243ca237b5fac12c98deaa5 -> 200
These workflows also run successfully in GitHub Actions, so this appears isolated to the extension/language-server validation path.
Why this matters
Security tooling such as OpenSSF Scorecard rewards pinning GitHub Actions by immutable SHA. Replacing SHAs with tags quiets the editor diagnostic but weakens supply-chain hardening and can reintroduce PinnedDependencies findings.
So the practical workaround is either to ignore Problems panel noise or to weaken action pinning. Neither is ideal.
Suspected cause
In the built extension bundle, the language server fetch path appears to call GitHub's Contents API for action metadata and returns undefined on failure:
repos.getContent({ owner, repo, ref, path: "action.yml" })
// fallback to action.yaml on 404
Then validation emits:
Unable to resolve action `<uses>`, repository or version not found
For full SHA refs, the action metadata is available, but the extension still reaches the unresolved path in some installations. I could not reproduce a failure with direct API calls using the same refs, which suggests the language server may be mishandling the ref, cache key, auth/API state, or a transient API error and collapsing it into a permanent repository or version not found diagnostic.
Suggested fix
A robust fix would be:
- Keep the existing Contents API lookup for
action.ymlandaction.yaml. - When the ref looks like a full commit SHA (
/^[0-9a-f]{40}$/i) and the Contents API path fails or returns no metadata, retry against the raw content URL before reporting a diagnostic:
async function fetchRawActionMetadata(action: ActionRef): Promise<string | undefined> {
for (const filename of ["action.yml", "action.yaml"]) {
const path = action.path ? `${action.path}/${filename}` : filename;
const url = `https://raw.githubusercontent.com/${action.owner}/${action.name}/${action.ref}/${path}`;
const response = await fetch(url);
if (response.ok) return await response.text();
}
return undefined;
}
- Only emit
repository or version not foundif both the Contents API and the raw fallback fail. - Ideally, distinguish network/auth/API errors from real repo/ref-not-found errors in the diagnostic message.
I tested this fallback locally by patching the bundled language-server files (dist/server-node.js and dist/server-web.js) to try raw.githubusercontent.com/.../action.yml and action.yaml before returning unresolved metadata. After reloading the editor, the SHA-pinned actions can be resolved without replacing SHAs with mutable tags.
Additional notes
The extension should continue to validate inputs after metadata is fetched. The proposed fallback only changes the metadata retrieval path for valid immutable refs; it does not suppress validation generally.
- 主要语言
- TypeScript
- 星标
- 661
- 派生
- 214
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github/vscode-github-actions 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 76/100
github/vscode-github-actions#627 · 1 个 reaction ·
-
long work 未关闭
难度 4/5 3-5 天 新手友好度 25/100
github/vscode-github-actions#628 ·
-
bug
难度 3/5 1-2 天 新手友好度 55/100
github/vscode-github-actions#625 ·
-
bug
难度 3/5 1-2 天 新手友好度 64/100
github/vscode-github-actions#621 · 3 条评论 ·
-
难度 3/5 1-2 天 新手友好度 50/100
github/vscode-github-actions#619 ·
查看 github/vscode-github-actions 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 75/100
-
bug v2
难度 2/5 1-3 小时 新手友好度 75/100
modelcontextprotocol/inspector#2458 · 1 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 75/100
railmapgen/rmp-gallery#4068 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
难度 2/5 1-3 小时 新手友好度 70/100
carbon-design-system/ibm-products#9907 ·