Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

CodeQL CLI update dialog blocks extension start / update dialog is easy to miss

未关闭
#905 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
typescript, vscode
领域
devtools

调研方向

从 extensions/ql-vscode/src/extension.ts 的第 207-208 行附近开始,然后通过等待 CodeQL CLI 发布版本或操纵 VS Code 全局存储来重现更新条件。验证被忽略的更新对话框如何影响扩展操作,并将完成标准定义为允许扩展启动,同时仍适当地显示更新通知。

由索引模型根据 Issue 内容生成。

描述

bug VSCode

Describe the bug
Relates to #297, #447

When a CodeQL CLI update is available the start of the extension is blocked until the user interacted with the update dialog, see:
https://github.com/github/vscode-codeql/blob/db66184c35410bc2545a9d9a1d37305c8b99c2e6/extensions/ql-vscode/src/extension.ts#L207-L208

However, personally I think the info dialog shown by VSCode is easy to miss, especially when there are other dialogs from other extensions (and VSCode collapses the CodeQL dialog?).
When you then overlook CodeQL's dialog, you will wonder why the extension is not working.

Version
Extension:

CodeQL extension version: 1.5.1 
CodeQL CLI version: 2.5.7 
Platform: win32 x64

VSCode:

Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19041

To reproduce

  1. Wait for the next CodeQL CLI release (maybe also possible with VSCode global storage manipulation)
  2. Start VSCode with the extension installed
  3. Activate the extension, for example by clicking on the "CodeQL" icon on the left sidebar
    ℹ️ The extension should show an info dialog about the CodeQL CLI update in the bottom right corner
  4. Ignore the update dialog (neither close it nor accept it)
  5. Try to use any extension action
    ❌ Nothing happens (note: from my memories; cannot test because there is no new CodeQL CLI release)

Expected behavior
Maybe the dialog should not be blocking and the extension should start with the existing CodeQL CLI?

主要语言
TypeScript
星标
539
派生
240
平均合并
2 天 18 小时
30 天内合并 PR
37

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

github/vscode-codeql 的其他 Issue

查看 github/vscode-codeql 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。