squad cast is not atomic: a failed AgentProvenanceError cast leaves an orphan member in team.md, routing.md and .squad/agents/
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
调研方向
Start with packages/squad-cli/src/cli/commands/cast.ts and trace runCastAdd through updateCastingStateWithAgent; read the registry reconciliation in packages/squad-sdk/src/casting/agent-provenance.ts and the caller in packages/squad-cli/src/cli-entry.ts. Check how existing cast and doctor tests cover failure handling. Done means a rejected cast leaves no partial member files or roster entries, reports a concise error, and squad doctor detects roster members missing from the registry.
由索引模型根据 Issue 内容生成。
描述
Version: CLI built from release/prepare-2.0.0-preview.5 @ 38d45d02 (package version 2.0.0-preview.6), macOS, Node.
What happens
squad cast --name <name> --role <role> writes the member's charter, history, team.md row and routing.md row before it updates the casting registry. When the registry update throws AgentProvenanceError, nothing is rolled back. The command exits 1 with a raw stack trace. The project is left with a member that is on the roster and in routing but not in .squad/casting/registry.json.
Retrying doesn't help. Without --force, it stops at "already exists". With --force, it hits the same AgentProvenanceError. The next squad upgrade then projects the orphan into .claude/agents/<id>.md, and squad doctor reports all checks passing.
Repro
D=$(mktemp -d); cd "$D"; git init -q
node <squad-cli>/dist/cli-entry.js init --roles --client copilot,claude
git add -A && git commit -qm init
node <squad-cli>/dist/cli-entry.js cast --name Alpha --role "Test Engineer" # ok
git add -A && git commit -qm alpha
node <squad-cli>/dist/cli-entry.js cast --name Beta --role "Test Engineer" # fails (see #2524)
echo $? # 1
git status --short
Output of the failing cast (stack trace printed verbatim to the user):
AgentProvenanceError: New agent id "beta" ambiguously resembles existing role owner(s) alpha; supply the existing stable id for a rename
at reconcileAgentProvenanceRegistry (.../squad-sdk/dist/casting/agent-provenance.js:963:23)
at updateCastingStateWithAgent (.../squad-cli/dist/cli/commands/cast.js:273:26)
at async runCastAdd (.../squad-cli/dist/cli/commands/cast.js:341:5)
...
git status after the failure:
M .squad/routing.md # + | Test Engineer | Beta | — |
M .squad/team.md # + | Beta | Test Engineer | `.squad/agents/beta/charter.md` | ✅ Active |
?? .squad/agents/beta/ # charter.md, history.md
.squad/casting/registry.json has no beta entry, and .squad/config.json is not updated either, because addAgentToConfig runs after the throw.
Then:
node <squad-cli>/dist/cli-entry.js cast --name Beta --role "Test Engineer" # ✗ Agent "Beta" already exists ... (use --force)
node <squad-cli>/dist/cli-entry.js cast --name Beta --role "Test Engineer" --force # same AgentProvenanceError
node <squad-cli>/dist/cli-entry.js upgrade # ✓ created .claude/agents/beta.md
node <squad-cli>/dist/cli-entry.js doctor # Summary: 13 passed, 0 failed, 0 warnings
Expected
- The cast either completes or changes nothing. Validate against the casting registry first (or stage everything and commit last), so a provenance rejection leaves
team.md,routing.md,.squad/agents/and.claude/agents/untouched. AgentProvenanceErroris shown as a one-line✗error with a hint, not an uncaught stack trace.squad doctorflags roster members (team.mdrows or.squad/agents/*/charter.md) that are missing from the casting registry.
Source
packages/squad-cli/src/cli/commands/cast.ts,runCastAdd(line 362). The order is: charter and history written (line 407),updateTeamMdWithAgent(412),ensureBuiltinRoster,updateRoutingMdWithAgent, and only thenupdateCastingStateWithAgent(415), which callsreconcileAgentProvenanceRegistry(line 319).packages/squad-sdk/src/casting/agent-provenance.ts, line 1194–1203: the throw site.- The CLI caller in
packages/squad-cli/src/cli-entry.ts(line ~922) doesn't catchAgentProvenanceError.
Related: #2524 (root cause of this particular rejection: two members can't share a role).
🤖 Generated with Claude Code
- 主要语言
- TypeScript
- 星标
- 3.4k
- 派生
- 516
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 116
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github/squad 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
相似的 Issue
-
bot:ai-assisted component:platform-js status:untriaged
难度 1/5 1 小时以内 新手友好度 74/100
midnightntwrk/platform-js#38 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
ranxianglei/billion-context#7068 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
mybigday/whisper.rn#348 ·
-
enhancement severity:low
难度 2/5 1-3 小时 新手友好度 82/100
Battle-Cattle/BCUK-Bot-4#1075 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
ilan-pinto/roaring-lions#1552 ·
维护者通常 1 天内回复