gh stack rebase --continue doesn't report new conflicts hit while resuming a multi-commit branch rebase
还没有人认领这个 Issue。
评估
调研方向
从 cmd/rebase.go 中的 continueRebase 开始,将其进行中的路径与 printConflictDetailsWithContinue 进行比较。然后跟踪 internal/git/gitops.go 中的 git.RebaseContinue 和 internal/git/git.go 中的 tryAutoResolveRebase;使用 gh stack rebase --continue 重现多提交冲突流程。当后续冲突报告当前的 Conflicted files 块,而不只是通用错误时,即表示完成。
由索引模型根据 Issue 内容生成。
描述
Summary
gh stack rebase --continue only prints Conflicted files: listing for first conflict encountered when cascading one stacked branch onto another. If resolving that conflict and continuing causes git to hit a second conflict on a later commit within the same branch's replay, the tool does not report what files are now conflicted and just returns a generic wrapped error.
This can make it look like there's only one conflicted file when there are actually more. You can only see the other conflicts by manually running git status.
Steps to reproduce
- Create a stack with a branch containing at least two commits and at least two files, where:
- Commit A modifies
file1.txtso that there's a conflict with the (rebased) parent branch. - Commit B later modifies
file2.txtso that it also conflicts with the parent branch, independently of commit A.
- Commit A modifies
- Rebase the stack
- The tool stops on commit A's conflict and correctly prints:
Conflicted files: C file1.tsx (lines N–M) - Resolve
file1.txt, stage it, rungh stack rebase --continueagain. - Git internally applies commit B next, which conflicts on
file2.txt.
Expected behavior
Step 5 should print the same kind of Conflicted files: block, listing file2.txt with its conflict line numbers, like step 3 did for file1.txt.
Actual behavior
Step 5 prints a generic error:
rebase continue failed — resolve remaining conflicts and try again: exit status 1
No indication of which file(s) are now conflicted. The only way to discover where the new conflict is is running git status manually.
Proposed solution / notes
I'll be honest, not familiar with Go so this "solution" is mostly Claude. I did double check that it looks at least mostly right to me. Figured it might be helpful.
Traced this to
cmd/rebase.goandinternal/git/git.go:
printConflictDetails()/printConflictDetailsWithContinue()(cmd/rebase.go:545) is the function that formats theConflicted files:block with per-file conflict-marker line numbers (viagit.FindConflictMarkers). It's only called from the branch-to-branch cascade logic, atcmd/rebase.go:259and:435.continueRebase()(cmd/rebase.go:312) has a separate path for resuming an already in-progressgit rebasewithin a single branch's multi-commit replay:This path never callsif git.IsRebaseInProgress() { rebaseOpts := git.RebaseOpts{CommitterDateIsAuthorDate: state.CommitterDateIsAuthorDate} if err := git.RebaseContinue(rebaseOpts); err != nil { return fmt.Errorf("rebase continue failed — resolve remaining conflicts and try again: %w", err) } }printConflictDetails.- Following
RebaseContinue(internal/git/gitops.go:334) intotryAutoResolveRebase(internal/git/git.go:118), the conflicted-files list is actually fetched — just to check whetherrererealready auto-resolved everything — and then discarded on the way out:conflicts, err := ConflictedFiles() if err != nil { return originalErr } if len(conflicts) > 0 { return originalErr // <-- conflicts is right here and gets thrown away }Fix: in
continueRebase, whengit.RebaseContinuereturns an error, callprintConflictDetailsWithContinue(using the still-in-progress rebase's current conflicted files, e.g. by callinggit.ConflictedFiles()again, or by threadingtryAutoResolveRebase's localconflictsslice out through the error) before returning, instead of just wrapping the raw error string. That gives resume-mid-branch conflicts the same reporting as cascade-boundary conflicts.
Environment
ghversion: 2.97.0 (2026-07-31)gh-stackextension:github/gh-stackv0.1.0- OS: macOS Tahoe 26.5.1
- 主要语言
- Go
- 星标
- 1.5k
- 派生
- 73
- 平均合并
- 1 天 8 小时
- 30 天内合并 PR
- 7
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github/gh-stack 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 85/100
-
难度 1/5 1 小时以内 新手友好度 92/100
-
feature request topic: cli - general
难度 2/5 1-3 小时 新手友好度 68/100
-
feature request topic: auto-merge
难度 2/5 1-3 小时 新手友好度 68/100
-
bug topic: docs
难度 1/5 1 小时以内 新手友好度 68/100
相似的 Issue
-
textual definition
难度 1/5 1 小时以内 新手友好度 90/100
geneontology/go-ontology#32653 ·
-
难度 1/5 1 小时以内 新手友好度 75/100
-
needs design
难度 2/5 1-3 小时 新手友好度 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100