Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

A failed link call leaves the target stack's membership partially mutated

未关闭
#374 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
github, go
领域
api, cli

调研方向

从 gh stack link 命令开始,按照此 issue 中的步骤重现失败,然后检查影响 repos/{owner}/{repo}/stacks/{id} 成员关系的调用。跟踪 PR 创建尝试失败时如何处理之前和之后的成员关系变更。完成标准是:失败的链接要么保留原始的 pull_requests 成员关系,要么明确报告每一项部分变更,并通过 API 进行验证。

由索引模型根据 Issue 内容生成。

描述

bug topic: cli - link

Summary

When gh stack link fails partway through (see #373 for one way to trigger this), the stack's membership on GitHub is left altered rather than restored — PRs that were part of the stack before the failed call are silently dropped from it, with no rollback and no mention of this in the command's error output.

Repro

  1. Build a stack main <- a <- b <- c <- d <- e via gh stack link. Confirm via gh api repos/{owner}/{repo}/stacks/{id} that all 5 PRs are listed under pull_requests.
  2. Merge a and b. Close c without merging.
  3. Run gh stack link a b c d e --base main to fix d's base (see #373) — it fails while trying to create a duplicate PR for a.
  4. Re-check the stack's membership: gh api repos/{owner}/{repo}/stacks/{id} --jq '.pull_requests[].number'.

Actual

Before step 3, the stack listed all 5 PRs. After the failed link call in step 3, the stack's pull_requests field lists only the merged PRs (a, b) — c, d, and e are gone from the stack entirely, even though d and e were never touched by the failed create attempt (only the lookup step "found" them, per #373's output).

This is also visible in the GitHub UI: PRs that previously showed a "Part of a stack" banner no longer show it at all.

I did not attempt to trigger this deliberately — it was an unwanted side effect discovered while working around #373 and #372.

Expected

Either:

  • The whole link operation should be atomic: a failure partway through (e.g. an individual PR-creation error) should not leave the stack's membership altered from before the call, or
  • If partial application is intentional/unavoidable, the command should clearly report which stack-membership changes actually took effect before it errored out, so the caller can reconcile the difference instead of discovering it later via the API or UI.

Environment

gh-stack version 0.0.8, installed via gh extension install github/gh-stack.

主要语言
Go
星标
1.5k
派生
73
平均合并
1 天 8 小时
30 天内合并 PR
7

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

github/gh-stack 的其他 Issue

查看 github/gh-stack 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。