Theme follows OS apps theme instead of terminal background on Windows, leaving text unreadable after a mid-session switch (still present in 1.0.89-1)
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- powershell
- 领域
- cli, operating-systems
调研方向
Start by locating the color-scheme detection and change-handling entry points, including startColorSchemeListener, the OSC 11 probe, and the theme() path described in the issue. Reproduce the Windows Terminal mid-session switch, then verify that the selected palette follows the terminal background and remains readable after a theme notification or retry.
由索引模型根据 Issue 内容生成。
描述
Describe the bug
On Windows, Copilot CLI decides light vs. dark from the OS apps theme, not from the terminal's actual background. When the OS theme flips mid-session (e.g. via Auto Dark Mode) while the terminal keeps a dark color scheme, the CLI repaints its text for a light background but the terminal background stays dark, leaving the UI unreadable.
Still present in 1.0.89-1
#4857 reports this same symptom on Windows and was closed as "resolved as of v1.0.88" by copilot-cli-bot. That closure looks premature - the detection and change-handling code is byte-identical between 1.0.85 and 1.0.89-1 apart from minified identifiers:
if (source === "native") { initial || (u++, m = "native", O()); return }
if (initial) { l = scheme, d = scheme, x(); return }
scheme !== d && (d = scheme, u++, c = scheme,
theme() === "github" ? x() : (m = "terminal", O()))
The hardcoded scheme === "light" ? { bg: #ffffff, fg: #1f2328 } : ... branch and its theme() === "github" || !terminalColors gate are also unchanged in 1.0.89-1.
Root cause
- Startup probes the terminal with
CSI ?996n/CSI ?2031h(2s timeout). - Windows Terminal implements neither -
DECRQM ?2031returns0on WT 1.24.11911.0. See microsoft/terminal#18375 (open, Backlog; implementation PR #20335 was rejected). - The probe times out, so the CLI falls back to the native OS watcher (
startColorSchemeListener), which reports the Windows apps theme (AppsUseLightTheme) - not the terminal background. - With the default
githubtheme, alightreport forces{ bg: #ffffff, fg: #1f2328 }regardless of the real background. The text repaint always happens, while the matching background write is gated behindtheme === "github" && truecolor && !refreshInFlight, so the two routinely disagree.
Only existing sessions break; a fresh session takes the initial path and renders fine.
Secondary: no recovery path
In 1.0.81-14 the listener re-queries only on an OS theme change, and Xlr() returns just a dispose function, so changing theme never forces a re-query. Once the palette is corrupted, /theme <x> prints "Color mode set to" but the stale bg/fg persist; the only recovery is another OS toggle or a restart. 1.0.85+ adds { modeChanged, dispose }, but a session whose palette is already wrong still cannot self-correct without an external trigger.
Tertiary: race when the terminal also switches
With theme: "system" plus "colorScheme": { "dark": ..., "light": ... }, the forced OSC 11 re-query and the terminal's repaint are both driven by the same WM_SETTINGCHANGE, with no ordering guarantee. The query can read the outgoing scheme, producing the inverse mismatch (light-mode text on the new dark background), with no retry to correct it.
Suggested fixes
- Prefer
OSC 11over the OS theme. Background lightness is what actually matters, and it stays correct for "light OS theme + dark terminal scheme" users. This is also the Windows Terminal maintainers' guidance in microsoft/terminal#20335; OSC 11 reports the new background promptly on WT 1.24.11911.0. - Add a settle delay / retry after an OS theme notification before trusting the query result.
- Allow pinning light/dark explicitly (already requested in #4620).
/themeonly selects a palette family (default|github|dim|high-contrast|colorblind); there is no supported way to force dark.
Workaround
/theme dim, or any non-github family - these derive from the queried terminal colors and skip the hardcoded light palette.
Affected version
1.0.89-1 (also 1.0.85, 1.0.81-14)
Steps to reproduce the behavior
- Windows Terminal with a dark color scheme ("One Half Dark") and
"theme": "dark". - Set the Windows apps theme to dark, then start
copilot. - While the session is running, flip the Windows apps theme to light (Auto Dark Mode, or Settings > Personalization > Colors).
- The terminal background correctly stays dark, but Copilot CLI repaints its text with the light palette - the UI becomes unreadable.
- On 1.0.81-14,
/theme <family>prints "Color mode set to: ..." but does not restore readability.
Expected behavior
Copilot CLI should follow the terminal's actual background (OSC 11) rather than the OS apps theme, and should stay readable when the two disagree. Failing that, provide a supported way to pin light/dark.
Additional context
- Operating system: Windows 11
- CPU architecture: x86_64
- Terminal emulator: Windows Terminal 1.24.11911.0
- Shell: Windows PowerShell
- Auto Dark Mode with
AppsSwitchenabled (flipsAppsUseLightTheme) - Reproduced on 1.0.81-14 and 1.0.85; code path verified unchanged in 1.0.89-1
- 主要语言
- Shell
- 星标
- 11.2k
- 派生
- 1.9k
- 平均合并
- 17 小时 6 分钟
- 30 天内合并 PR
- 5
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github/copilot-cli 的其他 Issue
-
area:sessions
难度 2/5 1-3 小时 新手友好度 72/100
github/copilot-cli#4996 ·
维护者通常 1 天内回复
-
triage
难度 1/5 1 小时以内 新手友好度 88/100
github/copilot-cli#4963 · 1 条评论 ·
维护者通常 1 天内回复
-
triage
难度 2/5 1-3 小时 新手友好度 75/100
github/copilot-cli#4932 ·
维护者通常 1 天内回复
-
triage
难度 2/5 1-3 小时 新手友好度 78/100
github/copilot-cli#4909 ·
维护者通常 1 天内回复
-
triage
难度 2/5 1-3 小时 新手友好度 76/100
github/copilot-cli#4906 ·
维护者通常 1 天内回复
查看 github/copilot-cli 的全部 Issue
相似的 Issue
-
Feature Needs Triage
难度 2/5 1-3 小时 新手友好度 72/100
project-chip/certification-tool#1154 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
beehive-lab/TornadoVM#1151 ·
维护者通常 1 天内回复
-
component/tests
难度 2/5 1-3 小时 新手友好度 72/100
NVIDIA/nodewright#735 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
obra/superpowers#2433 ·
维护者通常 5 天内回复