Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

CPP: IR weirdness with unexpected result for `getUnconvertedResultExpression`

未关闭
#21,249 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
cpp
领域
compilers

调研方向

从提供的 CodeQL 查询对 getUnconvertedResultExpression 的使用以及 test_direct_bool_context testcase 开始。比较第 28 行和第 29 行条件的 IR 与查询结果,然后验证 testcase 是否针对每个预期行各报告一个 alert,且第 28 行没有重复报告。

由索引模型根据 Issue 内容生成。

描述

question

(Kind of related to #21241 and #21240)

While testing my query, I noticed that I had a duplicate result for line 28 (if (&x)).
(Only visible when looking at the .expected file of my test output)
The IR supposedly had two address-of instruction at that line.
I don't understand why and looking at the IR the only difference between line 28 and 29 is that there is one CompareNE instruction in the one case and one CompareEQ instruction in the other case (as expected).

| twice!NonSSA: NonSSA: 8:ResultCopy | AddressOfNullCheck.c:28:9
 | twice!NonSSA: NonSSA: 7:ValCondCondCompare | AddressOfNullCheck.c:28:9
 | twice!NonSSA: NonSSA: 15:ResultCopy | AddressOfNullCheck.c:29:10

IR graph dump query
/**
 * @name ff
 * @description aa
 * @kind graph
 * @id aaaaa
 * @tags security
 */

import cpp
import semmle.code.cpp.ir.IR
import semmle.code.cpp.ir.PrintIR
import semmle.code.cpp.Declaration

private class Foo extends PrintIRConfiguration {
  override predicate shouldPrintDeclaration(Declaration decl) {
    decl.(Function).getName() = "test_direct_bool_context"
  }
}

Dot file
digraph {
  compound=true;
  subgraph cluster_0 {
    0[shape=point, width=0];
    "label"="void test_direct_bool_context()"; 
    
    subgraph cluster_1 {
      1[shape=point, width=0];
      "label"="Block 0"; 
      
      2["label"="v24_1(void) = EnterFunction : "; ];
      3["label"="m24_2(unknown) = AliasedDefinition : "; ];
      4["label"="m24_3(unknown) = InitializeNonLocal : "; ];
      5["label"="m24_4(unknown) = Chi : total:m24_2, partial:m24_3"; ];
      6["label"="r25_1(glval<int>) = VariableAddress[x] : "; ];
      7["label"="m25_2(int) = Uninitialized[x] : &:r25_1"; ];
      8["label"="r28_1(glval<int>) = VariableAddress[x] : "; ];
      9["label"="r28_2(int *) = CopyValue : r28_1"; ];
      10["label"="r28_3(int *) = Constant[0] : "; ];
      11["label"="r28_4(bool) = CompareNE : r28_2, r28_3"; ];
      12["label"="v28_5(void) = ConditionalBranch : r28_4"; ];
    }
    subgraph cluster_13 {
      13[shape=point, width=0];
      "label"="Block 1"; 
      
      14["label"="v28_6(void) = NoOp : "; ];
    }
    subgraph cluster_15 {
      15[shape=point, width=0];
      "label"="Block 2"; 
      
      16["label"="r29_1(glval<int>) = VariableAddress[x] : "; ];
      17["label"="r29_2(int *) = CopyValue : r29_1"; ];
      18["label"="r29_3(int *) = Constant[0] : "; ];
      19["label"="r29_4(bool) = CompareEQ : r29_2, r29_3"; ];
      20["label"="v29_5(void) = ConditionalBranch : r29_4"; ];
    }
    subgraph cluster_21 {
      21[shape=point, width=0];
      "label"="Block 3"; 
      
      22["label"="v29_6(void) = NoOp : "; ];
    }
    subgraph cluster_23 {
      23[shape=point, width=0];
      "label"="Block 4"; 
      
      24["label"="v30_1(void) = NoOp : "; ];
      25["label"="v24_5(void) = ReturnVoid : "; ];
      26["label"="v24_6(void) = AliasedUse : m24_3"; ];
      27["label"="v24_7(void) = ExitFunction : "; ];
    }
  }
  13 -> 15["label"="Goto"; "ltail"="cluster_13"; "lhead"="cluster_15"; ];
  21 -> 23["label"="Goto"; "ltail"="cluster_21"; "lhead"="cluster_23"; ];
  1 -> 15["label"="False"; "ltail"="cluster_1"; "lhead"="cluster_15"; ];
  15 -> 23["label"="False"; "ltail"="cluster_15"; "lhead"="cluster_23"; ];
  1 -> 13["label"="True"; "ltail"="cluster_1"; "lhead"="cluster_13"; ];
  15 -> 21["label"="True"; "ltail"="cluster_15"; "lhead"="cluster_21"; ];
}

Query
/**
 * @name Suspicious check on address-of expression
 * @description Taking the address of a valid object always produces a non-NULL
 *              pointer, so checking the result against NULL is either redundant
 *              or indicates a bug where a different check was intended.
 * @kind problem
 * @problem.severity warning
 * @precision high
 * @id asymmetric-research/suspicious-address-of-null-check
 * @tags reliability
 *       correctness
 *       readability
 */

import cpp
import semmle.code.cpp.controlflow.Guards
/**
 * Technically, we'd ignore cases where we do something like &foo->first_field (where foo is a pointer)
 * this is because if foo is NULL, the expression could actually evaluate to NULL.
 * However, it doesn't seem likely that anyone would write code like that intentionally
 * and it's also undefined behavior to dereference a NULL pointer anyway.
 */
class ValidAddressOfExpr extends AddressOfExpr { }


from Instruction source
where
  source.getUnconvertedResultExpression() instanceof ValidAddressOfExpr and
    source.getLocation().getStartLine() = [28, 29]
select source, "twice!" + source.getUniqueId()

Testcase
#define NULL ((void*)0)

struct foo {
    int a;
    long b;
};
typedef struct foo foo_t;

int global_var;
int global_array[10];

// Test direct comparisons with local variables
void test_direct_comparison_local(void) {
    int x;

    // Direct comparison of address-of with NULL - should alert
    if (&x == NULL) {}       // $ Alert
    if (&x != NULL) {}       // $ Alert
    if (NULL == &x) {}       // $ Alert
    if (0 == &x) {}          // $ Alert
}

// Test direct boolean context with local variables
void test_direct_bool_context(void) {
    int x;

    // Direct use in boolean context - should alert
    if (&x) {}               // $ Alert DUPLICATE HERE
    if (!&x) {}              // $ Alert
}
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 16 小时
30 天内合并 PR
143

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

github/codeql 的其他 Issue

查看 github/codeql 的全部 Issue

相似的 Issue

更多 Compilers Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。