Repositories exclusion not working for empty repos

未关闭
#1,014 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
github-actions, javascript
领域
devops

调研方向

从 deployment-settings.yml 中的排除配置开始,跟踪 GitHub Action 的设置强制执行入口直到 branch-protection 请求。使用一个被排除的空仓库重现问题,然后验证被排除的仓库会在任何强制执行调用之前被跳过,而未被排除的仓库仍会强制执行设置。

由索引模型根据 Issue 内容生成。

描述

bug

Problem Description

I have this deployment-settings.yml:

restrictedRepos:
  exclude:
    - repo-A
    - repo-B
    - myrepo

Settings are NOT enforced on myrepo as expected, but such enforcement is triggered on both repo-A and repo-B. Such enforcement fails cause repo-A and repo-B are still empty and an error is thrown.

What is actually happening

The settings enforcement is triggered even if repository is listed among the excluded ones.

What is the expected behavior

That the excluded repositories are actually excluded by any kind of attempt of settings enforcement.

Error output, if available

Error applying branch protection.

 {
  "name":"HttpError",
  "status":404,
  "data": {
    "message":"Branch not found",
    "documentation_url":"https://docs.github.com/rest/branches/branch-protection#update-branch-protection",
    "status":"404"
  }
}

Such error is totally fair cause the repos are effectively empty. But why does it matter since the repo should be excluded? It seems such exclusion is ignored.

Context

Are you using the hosted instance of probot/settings or running your own?

My own, deployed via Github action as per documentation

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

probot/13.4.4

Version of GitHub Enterprise
主要语言
JavaScript
星标
942
派生
238
PR 合并指标
30 天内没有已合并 PR

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

github-community-projects/safe-settings 的其他 Issue

查看 github-community-projects/safe-settings 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。