TeamSettings schema missing include/exclude repo filter declarations
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 70/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 冷清
- 技术栈
- javascript
调研方向
首先比较 schema/repos.json、schema/settings.json、schema/suborgs.json 中的 CollaboratorSettings 定义及其解除引用后的对应定义,然后阅读 docs/github-settings/4. teams.md、docs/sample-settings/settings.yml 和现有的 Collaborators 测试。完成标准是:schemas 接受 team include/exclude 过滤器,Teams 指南和示例展示这两种形式,并且 Teams 测试覆盖过滤器路径。
由索引模型根据 Issue 内容生成。
描述
Prerequisites:
-
Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature.
N/A — this request is for schema validation and documentation of an existing safe-settings feature, not a new GitHub API capability.
-
Is the functionality available through the GitHub API? If the functionality is available, please provide links to the API documentation (https://developer.github.com/v3/) as well as the Octokit documentation (https://octokit.github.io/).
N/A —
include/excluderepo filtering is internal safe-settings logic (theDiffableclass), not a GitHub API concept. The filtering already works at runtime forteamsentries; it is simply not declared in the schema or covered in the documentation.
New Feature
The teams section of a safe-settings configuration already supports include and exclude repo filters at runtime via the same Diffable logic used by collaborators. However, unlike collaborators, these keys are not declared in the TeamSettings JSON schema and are not documented in the teams guide.
This means:
- Editors and linters that validate configuration files against the schema report
include/excludeas unknown properties on team entries, even though they are valid and functional. - There is no official documentation or example showing users how to use per-repo filtering for teams.
Please describe the desired new functionality:
-
The
TeamSettingsdefinition inschema/repos.json,schema/settings.json, andschema/suborgs.json(and their dereferenced counterparts) should declareincludeandexcludeusing the sameallOfpattern already used byCollaboratorSettings, so that editors and schema validators accept these fields without warnings. -
The teams guide should document
includeandexcludewith descriptions and YAML examples consistent with the collaborators guide. -
The sample settings file should include representative team entries demonstrating both
includeandexclude. -
Unit tests should cover the include/exclude filter code path for the
Teamsplugin, mirroring the coverage that exists forCollaborators.
No changes to runtime logic are required.
- 主要语言
- JavaScript
- 星标
- 942
- 派生
- 238
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github-community-projects/safe-settings 的其他 Issue
-
Teams: teams with organization-role access show up as deletions可能已有人在做 @TovaBecker 于 1 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 83/100
github-community-projects/safe-settings#1144 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1143 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1135 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
github-community-projects/safe-settings#1134 ·
维护者通常 2 天内回复
-
environments: additive_plugins is ignored, undeclared environments are deleted可能已有人在做 @yaunj 于 12 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
github-community-projects/safe-settings#1133 ·
维护者通常 2 天内回复
查看 github-community-projects/safe-settings 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
cytoscape/cytoscape.js#3597 ·
维护者通常 5 天内回复
-
priority: low server testing
难度 1/5 1 小时以内 新手友好度 88/100
blamechris/chroxy#9277 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
sunososobro-hub/cloudball#191 ·
维护者通常 1 天内回复
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
area:post effort:low enhancement P7 source:agent
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复