Numeric issue IDs bypass project-scoped MCP sessions

未关闭
#2,237 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
30/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
typescript
领域
cli, security

调研方向

Start with the project-scoped check added in commit 01b06bba (#1922) and see how it validates org-qualified targets and short IDs against the session's project. Then trace how issue view resolves a numeric ID to an issue and where the CLI could fetch the issue's project before reading or changing it. Done means a numeric ID outside the session's project is rejected in a sentry mcp --commands session, with tests covering the case.

由索引模型根据 Issue 内容生成。

描述

Part of #1357. Found while reviewing #1922.

In a project-scoped sentry mcp --commands session, an issue command that takes a numeric ID can read or change an issue in another project of the same org. For example, issue view 12345 in an acme/web session reaches an issue that lives in acme/api. The command surface checks each target before the call, but a numeric ID doesn't say which project the issue belongs to, so it can't be checked there.

  • Org-qualified targets and issue short IDs are already checked against the session's project in #1922 (01b06bba). Numeric IDs are the remaining path.
  • The same gap applies to any other command that resolves an opaque ID to a project-owned resource.
  • Proposal (BYK, while reviewing #1922): after looking up the issue, the CLI compares its project with the session constraint before reading or changing anything. Since that's a CLI change outside #1922's command surface, it lands separately.

via @BYK.

--

View Session [Sentry]

主要语言
TypeScript
星标
961
派生
179
平均合并
15 小时 33 分钟
30 天内合并 PR
476

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

getsentry/toolkit 的其他 Issue

查看 getsentry/toolkit 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。