`getDefaultIntegrations` no longer extends the base set

未关闭 适合新手
#24,039 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
84/100
Issue 类型
文档
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
documentation

调研方向

阅读 packages/cloudflare/src/baseSdk.ts:45、sdk.ts:13 和 request.ts:9,然后比较默认集成集合以及 issue 中描述的相关历史。更新注释,使其准确描述相同的集合,并删除任何不起作用的建议;确认文档一致且未更改任何功能。

由索引模型根据 Issue 内容生成。

描述

Cloudflare Workers javascript

packages/cloudflare/src/baseSdk.ts:45 documents that "getDefaultIntegrations in sdk.ts extends this set with the integrations that do depend on Node.js APIs". sdk.ts:13 is:

export function getDefaultIntegrations(options: CloudflareOptions): Integration[] {
  return getBaseDefaultIntegrations(options);
}

The two sets are identical. packages/cloudflare/src/request.ts:9 then tells users to "pass defaultIntegrations: getDefaultIntegrations(options) in options to get the full set instead", which is now a no-op.

Work item. Work out whether a nodejs_compat-only integration was dropped or never added. Then either restore it or correct both doc comments. Do not leave advice in the docs that does nothing.

**Prior art **(related history only). No issue, but the cause is clear from the history. getsentry/sentry-javascript#21881 added a separate /nodejs_compat entrypoint with the larger integration set, and getsentry/sentry-javascript#22900 "Make the nodejs_compat entrypoint the default" folded it into the default entrypoint and removed it, closing #18803. The two sets became identical at that point and the doc comments were not updated. This is documentation cleanup, not lost functionality.

主要语言
TypeScript
星标
8.7k
派生
1.9k
平均合并
1 天 18 小时
30 天内合并 PR
543

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

getsentry/sentry-javascript 的其他 Issue

查看 getsentry/sentry-javascript 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。