pwclient/xml-rpc: Returned patchid for hash is not the latest
还没有人认领这个 Issue。
评估
调研方向
从 pwclient/xml-rpc 的补丁查询入手,检查 Python SQL 抽象层如何选择和排序补丁。确认返回的补丁按日期是最新的,然后验证 acceptance hook 更新的是重新提交的补丁,而不是较早的 patchset。
由索引模型根据 Issue 内容生成。
描述
It looks like the hook to mark patches as accepted is closing the first instance of a patch. But quite often this is wrong because the patch is in a patchset was resubmitted. So the first patch (which was marked as "changes requested", "superseeded" or even "rejected") is accidentally marked as accepted and the actual patch (which is marked as "under review" or "new") still has the old state.
I would therefore propose as initial way to fix it to change the order of the patches in the query for patches and return the one with the "highest date". But I have no idea how this python sql abstraction works and how to add this change to get ordering to "date desc".
- 主要语言
- Python
- 星标
- 317
- 派生
- 91
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
getpatchwork/patchwork 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
getpatchwork/patchwork#668 ·
-
bug web-ui
难度 2/5 1-3 小时 新手友好度 74/100
getpatchwork/patchwork#546 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 52/100
getpatchwork/patchwork#664 ·
-
难度 4/5 3-5 天 新手友好度 48/100
getpatchwork/patchwork#663 ·
-
难度 3/5 1-2 天 新手友好度 45/100
getpatchwork/patchwork#645 ·
查看 getpatchwork/patchwork 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 90/100
learningequality/ricecooker#747 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 76/100
run-llama/llama_index#23199 ·
-
难度 2/5 1-3 小时 新手友好度 84/100
KhronosGroup/glTF-Blender-IO#2769 ·