Bulk removal of MCP clients: filter before the transaction per client, and skip only a foreign key refusal

未关闭
#3,448 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
58/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp

调研方向

Start with src/FluentCMS.Core/Identity/Oidc/McpClients.cs and trace RemoveOpenApprovedAsync and RemoveUnusedAsync, focusing on where the span and open-approved filter are applied and how save failures are handled. Add tests that count which clients the query touches and confirm only a foreign key refusal is skipped; other save failures should propagate. Done when both behaviors are covered and the bulk removal still respects the 100-client ceiling.

由索引模型根据 Issue 内容生成。

描述

area:identity plugin type:bug

Follow-ups of the bulk removal of self-registered MCP clients (#3397, #3434), found in its second review. src/FluentCMS.Core/Identity/Oidc/McpClients.cs.

  • The span is applied after a transaction is opened per client. RemoveOpenApprovedAsync opens an IdentityChanges transaction and reads again every client the open policy approved, those outside the span included. The ceiling of 100 bounds the deletes, not the scan: a call costs up to maxClients (which can be set to 100000) empty transactions. A cost, not a wrong answer.
  • Any save failure is taken as "a consent arrived". catch (DbUpdateException) in the bulk removal and in RemoveUnusedAsync takes every failure of the save, a failed outbox write included, as the foreign key refusal it was written for. A failure that lasts would answer 200 with { removed: 0, more: false } and one warning 9009 per client.

Wanted

  • The span and the open-approved filter applied in the query, so that a call touches only its candidates, with a test that counts.
  • Only a foreign key refusal skipped; another failure thrown, with a test.

Bundle 26.

主要语言
C#
星标
567
派生
107
平均合并
1 小时 19 分钟
30 天内合并 PR
353

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。