Bulk removal of MCP clients: filter before the transaction per client, and skip only a foreign key refusal
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 58/100
调研方向
Start with src/FluentCMS.Core/Identity/Oidc/McpClients.cs and trace RemoveOpenApprovedAsync and RemoveUnusedAsync, focusing on where the span and open-approved filter are applied and how save failures are handled. Add tests that count which clients the query touches and confirm only a foreign key refusal is skipped; other save failures should propagate. Done when both behaviors are covered and the bulk removal still respects the 100-client ceiling.
由索引模型根据 Issue 内容生成。
描述
Follow-ups of the bulk removal of self-registered MCP clients (#3397, #3434), found in its second review. src/FluentCMS.Core/Identity/Oidc/McpClients.cs.
- The span is applied after a transaction is opened per client.
RemoveOpenApprovedAsyncopens anIdentityChangestransaction and reads again every client the open policy approved, those outside the span included. The ceiling of 100 bounds the deletes, not the scan: a call costs up tomaxClients(which can be set to 100000) empty transactions. A cost, not a wrong answer. - Any save failure is taken as "a consent arrived".
catch (DbUpdateException)in the bulk removal and inRemoveUnusedAsynctakes every failure of the save, a failed outbox write included, as the foreign key refusal it was written for. A failure that lasts would answer 200 with{ removed: 0, more: false }and one warning 9009 per client.
Wanted
- The span and the open-approved filter applied in the query, so that a call touches only its candidates, with a test that counts.
- Only a foreign key refusal skipped; another failure thrown, with a test.
Bundle 26.
- 主要语言
- C#
- 星标
- 567
- 派生
- 107
- 平均合并
- 1 小时 19 分钟
- 30 天内合并 PR
- 353
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
fluentcms/FluentCMS 的其他 Issue
-
area:localization plugin type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:storage type:bug
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 1 天内回复
-
area:testing type:bug
难度 3/5 1-2 天 新手友好度 72/100
维护者通常 1 天内回复
-
area:api area:publishing type:feature
难度 4/5 3-5 天 新手友好度 55/100
fluentcms/FluentCMS#3473 · 1 条评论 ·
维护者通常 1 天内回复
-
area:storage plugin type:bug
难度 5/5 一周以上 新手友好度 35/100
维护者通常 1 天内回复
查看 fluentcms/FluentCMS 的全部 Issue
相似的 Issue
-
[Bug]: Threading.Analyzers 0.7.79 does not load on the .NET 10 SDK (CS9057), CHT rules silently off未关闭bug regression threading
难度 2/5 1-3 小时 新手友好度 74/100
CryptoHives/Foundation#362 ·
维护者通常 1 天内回复
-
bug need-triage
难度 2/5 1-3 小时 新手友好度 65/100
Fervent-Tempo/AF-Media-Bar#321 ·
-
a-corriger documentation
难度 1/5 1 小时以内 新手友好度 87/100
christian-raj/S-Aloha#345 ·
-
bug 要トリアージ
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 1 天内回复
-
worldInstancedOccluderNode reads its appendix count as one byte, but it is a VLQ可能已有人在做 @spuddeh 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 78/100
维护者通常 1 天内回复