Sign-in hardening: count parallel wrong passwords of a session, and small follow-ups of the signed-in count

未关闭
#3,447 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp

调研方向

Start in src/FluentCMS.Core/Identity/ and trace CmsUserManager.ChangePasswordAsync, TwoFactorService.RequireCodeAsync, ClearingPasswordChangeAsync, SetPasswordAsync, and CmsUserStore.cs; the issue also names docs/host-configuration.md. Read the linked follow-ups and their review context, then find the existing tests for these flows. Done means the five listed behaviors are covered by code, tests, or the specified spec update, and the documentation sentence is corrected.

由索引模型根据 Issue 内容生成。

描述

area:identity security type:bug

Follow-ups of #3371, #3378 and #3381 (#3444), found in its review. Paths are under src/FluentCMS.Core/Identity/.

  • Parallel wrong passwords on change-password are not all counted. CmsUserManager.ChangePasswordAsync ignores the result of SignedInAccessFailedAsync, as it ignored AccessFailedAsync before. A holder of a stolen cookie who posts N guesses at once has them all read one concurrency stamp: each answers "wrong password", one save wins, and the count rises by one. A right guess that loses its save answers ConcurrencyFailure, which tells the sender it was right. The per-address Auth limit (20 a minute) is then the only bound, against the intended 5 in 5 minutes. Codes are not affected, since a right code must win its own save.
  • A right two-factor code resets the count of wrong passwords too. ResetSignedInFailuresAsync is called from TwoFactorService.RequireCodeAsync, so a session that holds the second factor gives 4 wrong passwords, one right code at /me/two-factor/recovery-codes, and starts again.
  • The forced-change flag is put back over a reloaded user. ClearingPasswordChangeAsync and SetPasswordAsync restore mustChangePassword after a failed save without checking that the user was not reloaded, the pattern #3381 fixed for the failure count. No path of core saves the user again in that scope today.
  • IsTokenKeyViolation matches the table name anywhere in the provider's message (CmsUserStore.cs). SQL Server repeats the duplicate key value, so another unique violation whose value contains cms_user_token would be answered as a refusal. It can never become a success.
  • docs/host-configuration.md still says the token endpoint refuses a code or refresh token of a locked-out user, which #3271 ended.

Wanted

  • Every wrong current password of a session counted when requests run at once, and no different answer for a right one that lost its save, with a test.
  • Wrong passwords and wrong codes of a session counted apart, or the reason they share a count recorded in the spec.
  • The flag restored only when the user was not reloaded.
  • The token key matched by the constraint's name on the three providers.
  • The sentence corrected.

Bundle 28.

主要语言
C#
星标
567
派生
107
平均合并
1 小时 19 分钟
30 天内合并 PR
353

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。