Row rules on grants: accepted for a type they are not registered for, and ignored beside core permissions
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 52/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- csharp
调研方向
Start with RoleService.ValidateGrant, EffectiveGrant.Applies, and EffectivePermissions.Allows, then review spec 4.8 and the tests for GET /permissions and GET /permissions/row-rules. Add coverage for a row rule registered to a different content type, a row rule beside a non-content permission, and grants limited to another site. Done means the behavior follows the spec and each case has a test.
由索引模型根据 Issue 内容生成。
描述
Found in the review of #3440 (#3417). Both fail closed or stay within what the caller may hand out; neither is an escalation.
- A row rule is accepted for a content type it is not registered for.
RoleService.ValidateGrantchecksrules.Has(name)only.POST /roleswith{ "permission": "content.person.update", "constraints": { "rowRule": "news" } }, wherenewsis registered forpagealone, answers 201. The grant then matches no row (EffectivePermissions.RuleFilteranswers null), without a word. The admin can avoid it withtypeNamesofGET /permissions/row-rules; an API caller gets noFCMS3042. - A row rule on a grant of a permission that is not a content permission is accepted and ignored.
EffectiveGrant.AppliesandEffectivePermissions.Allowsdo not look atRowRule, so a role with*orusers.manageandrowRule: "own-entries"holds the core permissions in full. Spec 4.8 gives a resource-limited*no core permission and says nothing for row rules. - No test reads
GET /permissionsorGET /permissions/row-ruleswith a grant limited to another site. Every test uses an instance-wide role, so a change of the site passed to the check would pass them all.
Wanted
- A grant whose row rule is not registered for the content type of its permission is refused with
FCMS3042, with a test. - A decision, in spec 4.8, on a row rule beside a permission that is not a content permission: refused, or a grant that gives no core permission, with a test.
- The two tests with a grant limited to another site.
Bundle 27.
- 主要语言
- C#
- 星标
- 567
- 派生
- 107
- 平均合并
- 1 小时 19 分钟
- 30 天内合并 PR
- 353
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
fluentcms/FluentCMS 的其他 Issue
-
area:localization plugin type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:storage type:bug
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 1 天内回复
-
area:testing type:bug
难度 3/5 1-2 天 新手友好度 72/100
维护者通常 1 天内回复
-
area:api area:publishing type:feature
难度 4/5 3-5 天 新手友好度 55/100
fluentcms/FluentCMS#3473 · 1 条评论 ·
维护者通常 1 天内回复
-
area:storage plugin type:bug
难度 5/5 一周以上 新手友好度 35/100
维护者通常 1 天内回复
查看 fluentcms/FluentCMS 的全部 Issue
相似的 Issue
-
fix(ocr): compile the Tesseract-free pipeline with Tokio runtime可能已有人在做 @Goldziher 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
priority:P2
难度 2/5 1-3 小时 新手友好度 82/100
-
bug sev-5 vm
难度 2/5 1-3 小时 新手友好度 76/100
-
难度 2/5 1-3 小时 新手友好度 85/100
-
area:jobads-cv bug FE mvp P3
难度 2/5 1-3 小时 新手友好度 77/100
klasolsson81/jobbliggaren#2271 ·
维护者通常 1 天内回复