Site deletion can orphan entries, and the plugin and site caches reload under every request at once
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- csharp
- 领域
- backend, databases, performance
调研方向
Start with Sites/SiteManager.cs:176-181 and Storage/SystemModelBuilder.cs to trace site deletion and document storage; compare SiteManager.cs:418-422 for the existing NOT EXISTS pattern. Then read the content write transaction and the cache refresh paths in Plugins/PluginState.cs:88-108, src/plugins/FluentCMS.Plugins.MultiSite/SiteHostMap.cs:36-56, and Sites/SiteCache.cs. Done means all four acceptance cases have tests and pass.
由索引模型根据 Issue 内容生成。
描述
Problem
- Site deletion can orphan content.
Sites/SiteManager.cs:176-181checks for documents and then deletes the site as two statements with no transaction.cms_documenthas no foreign key to the site (Storage/SystemModelBuilder.cs), while locales and roles cascade. Other instances keep the site cached for 30 s (Sites/SiteCache.cs:15,Sites/SiteResolver.cs:107-110). An entry created between the check and the delete, or on another instance within 30 s, is left in a site that no longer exists and cannot be reached, restored or purged through the API. - The plugin and site caches reload under every request at once.
Plugins/PluginState.cs:88-108andsrc/plugins/FluentCMS.Plugins.MultiSite/SiteHostMap.cs:36-56have a fixed 30 s lifetime and no single-flight, so every request arriving after expiry runs the query.SiteCache.Invalidate()clears every key (Sites/SiteCache.cs:89-94).
Paths are under src/FluentCMS.Core/ unless they start with src/.
Proposal
- Delete with
NOT EXISTSin one statement, asRemoveLocaleAsyncdoes (SiteManager.cs:418-422), and re-check the site inside the content write transaction. - Refresh each cache once, serving the previous copy to other callers meanwhile.
Acceptance
- A site that gains an entry during deletion is not deleted
- A write to a site deleted on another instance is refused
- Concurrent requests after expiry run one refresh query
- Tests for each
Found in the code review of 17 Nov 2026.
- 主要语言
- C#
- 星标
- 569
- 派生
- 107
- 平均合并
- 2 小时 49 分钟
- 30 天内合并 PR
- 397
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
fluentcms/FluentCMS 的其他 Issue
-
area:host area:operations type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:build security type:chore
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:sdk security type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:content security type:bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
area:build type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
查看 fluentcms/FluentCMS 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
bug needs-triage
难度 2/5 1-3 小时 新手友好度 67/100
microsoft/microsoft-ui-reactor#1567 ·
维护者通常 1 天内回复
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
难度 2/5 1-3 小时 新手友好度 76/100
openclaw/openclaw-windows-node#2287 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
kind:ux needs-triage
难度 2/5 1-3 小时 新手友好度 66/100
elsa-workflows/elsa-foundation#4742 ·
维护者通常 1 天内回复
-
priority:P2
难度 2/5 1-3 小时 新手友好度 88/100