A burst of deliveries to one webhook drains at about one per timeout

未关闭
#3,268 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp

调研方向

Read src/plugins/FluentCMS.Plugins.Webhooks/WebhookDeliveryJob.cs:142-151 and WebhookQueueTests.TwoDeliveriesToOneWebhookNeverRunAtOnce first. Trace how a completed delivery schedules the next waiting attempt and how attempts are ordered by event time. Done means bursts reach a fast receiver at roughly its response time per event, in event order, without waiting jobs rerunning while another attempt is in flight.

由索引模型根据 Issue 内容生成。

描述

performance plugin type:bug

Problem

While a webhook has an attempt in flight, WebhookDeliveryJob (src/plugins/FluentCMS.Plugins.Webhooks/WebhookDeliveryJob.cs:142-151) reschedules every other attempt for it to busy.CreatedAt + Timeout plus jitter, the worst-case end of the send. WebhookQueueTests.TwoDeliveriesToOneWebhookNeverRunAtOnce asserts that wait. 1,000 events to a receiver that answers in 200 ms take hours; each round re-runs every waiting job (O(N²)) on the webhooks queue all sites share; jitter reorders events of one entry.

Proposal

Let a finished attempt wake the oldest waiting one (or keep a per-webhook FIFO drained by one job), order attempts by event time, and back off from now rather than from the worst case if polling stays.

Acceptance

  • N events to a fast receiver are delivered in about N times its response time, in event order
  • Waiting attempts do not re-run while one is in flight

Found in the code review of 17 Nov 2026 (P1).

主要语言
C#
星标
569
派生
107
平均合并
2 小时 49 分钟
30 天内合并 PR
397

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。